From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Vinod Koul <vinod.koul@linux.intel.com>,
Eric Miao <eric.y.miao@gmail.com>, Leo Yan <leoy@marvell.com>,
alsa-devel@alsa-project.org,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Liam Girdwood <lrg@ti.com>, Chao Xie <cxie4@marvell.com>,
Qiao Zhou <zhouqiao@marvell.com>,
Zhangfei Gao <zhangfei.gao@marvell.com>,
zhangfei gao <zhangfei.gao@gmail.com>,
alsa-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ASoC: mmp: add audio dma support
Date: Tue, 29 May 2012 10:02:15 +0100 [thread overview]
Message-ID: <20120529090215.GA3954@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120529073334.GA12217@n2100.arm.linux.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 561 bytes --]
On Tue, May 29, 2012 at 08:33:34AM +0100, Russell King - ARM Linux wrote:
> But, as I pointed out earlier, there's the issue of using the wrong
> struct device to allocate memory for the DMA engine. That's something
> that my soc-dmaengine.c got _right_, and soc-dmaengine-pcm.c gets _wrong_.
What is the issue with the current code - it *looks* like you want to
use the component device for the DMA as the struct device with dmaengine
but I don't understand the issue that's created if we don't (and why
things appear to be working for people as they are).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-05-29 9:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1337929863-31885-1-git-send-email-zhangfei.gao@marvell.com>
[not found] ` <1337929863-31885-3-git-send-email-zhangfei.gao@marvell.com>
2012-05-25 7:53 ` [PATCH 2/4] ASoC: mmp: add audio dma support Vinod Koul
2012-05-25 8:05 ` Russell King - ARM Linux
2012-05-25 8:47 ` zhangfei gao
2012-05-25 9:42 ` Russell King - ARM Linux
2012-05-29 5:14 ` zhangfei gao
2012-05-29 5:18 ` Vinod Koul
2012-05-29 7:33 ` Russell King - ARM Linux
2012-05-29 7:57 ` zhangfei gao
2012-05-29 8:01 ` [alsa-devel] " Russell King - ARM Linux
2012-05-29 9:02 ` Mark Brown [this message]
2012-05-29 9:21 ` Russell King - ARM Linux
2012-05-29 11:03 ` Lars-Peter Clausen
2012-05-29 13:14 ` Mark Brown
2012-05-29 13:46 ` Russell King - ARM Linux
2012-05-29 23:55 ` Mark Brown
[not found] ` <1337929863-31885-4-git-send-email-zhangfei.gao@marvell.com>
2012-05-28 14:59 ` [PATCH 3/4] ASOC: mmp: add sspa support Mark Brown
2012-05-29 5:23 ` zhangfei gao
[not found] ` <1337929863-31885-5-git-send-email-zhangfei.gao@marvell.com>
2012-05-28 15:13 ` [PATCH 4/4] ASoC: add mmp brownstone support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529090215.GA3954@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-devel@vger.kernel.org \
--cc=cxie4@marvell.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=leoy@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=vinod.koul@linux.intel.com \
--cc=zhangfei.gao@gmail.com \
--cc=zhangfei.gao@marvell.com \
--cc=zhouqiao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox