On Wed, Jun 20, 2012 at 07:47:25AM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > There's a dependency but no #include. > I don't mind to put it, but it wasn't done because we didn't want to > let the driver code including only pcm_params.h without pcm.h. I noticed it because I was writing some library code which only directly referenced things in pcm_params.h so just included that directly. The general idea is that headers shouldn't have external dependencies...