On Wed, Jun 20, 2012 at 05:00:30PM -0400, Scott Jiang wrote: Applied, thanks. There is one minor fixup below - please send an incremental patch for that. > The SPORT(Serial Port) module on bf6xx soc has a totally different ip comparing to bf5xx > soc. An individual SPORT module consists of two independently configurable SPORT halves > with identical functionality. Each SPORT half can be configured for either transmitter > or receiver. Please take more care with the formatting of your changelogs, they should be wrapped to within 80 columns and the subject line should correspond to the subsystem style. I reflowed. > +static irqreturn_t sport_err_irq(int irq, void *dev_id) > +{ > + struct sport_device *sport = dev_id; > + struct device *dev = &sport->pdev->dev; > + > + if (sport->tx_regs->spctl & SPORT_CTL_DERRPRI) > + dev_dbg(dev, "sport error: TUVF\n"); > + if (sport->rx_regs->spctl & SPORT_CTL_DERRPRI) > + dev_dbg(dev, "sport error: ROVF\n"); These should be dev_err() not dev_dbg() - they're errors.