From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, mr.swami.reddy@ti.com,
Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH] ALSA: ASoC: Remove const attribute from lm49453's snd_soc_dai_driver
Date: Wed, 27 Jun 2012 12:44:59 +0100 [thread overview]
Message-ID: <20120627114458.GH308@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hpq8lrnjr.wl%tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 584 bytes --]
On Wed, Jun 27, 2012 at 01:39:52PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> > It's fixed in -next, not in for-3.5. I guess I'll pick the change over
> > at some point.
> Ideally, such a problem should have been fixed for 3.5 by just
> removing const, and add const again once after ASoC core is changed
> for 3.6. But I've been ignoring this warning since it's certainly no
> big issue.
The fix in -next is to remove the const, it's not simply a case of
adding the const in the core as we currently fiddle with the ops structs
to add default ops (which we shouldn't do).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-06-27 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 7:34 [PATCH] ALSA: ASoC: Remove const attribute from lm49453's snd_soc_dai_driver Daniel Mack
2012-06-27 10:17 ` Mark Brown
2012-06-27 10:21 ` Daniel Mack
2012-06-27 10:25 ` Takashi Iwai
2012-06-27 11:11 ` Mark Brown
2012-06-27 11:39 ` Takashi Iwai
2012-06-27 11:44 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627114458.GH308@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=mr.swami.reddy@ti.com \
--cc=tiwai@suse.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox