From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@ti.com>
Cc: alsa-devel@alsa-project.org, Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH] ASoC: dapm: Fix locking during codec shutdown
Date: Fri, 6 Jul 2012 18:20:29 +0100 [thread overview]
Message-ID: <20120706172029.GI4017@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1341594613.4963.11.camel@odin>
[-- Attachment #1.1: Type: text/plain, Size: 629 bytes --]
On Fri, Jul 06, 2012 at 06:10:13PM +0100, Liam Girdwood wrote:
> On Fri, 2012-07-06 at 17:43 +0100, Mark Brown wrote:
> > So how is suspend and resume safe, for example? It's the same general
> > path through the PM core.
> suspend and resume are safe as they call stream_event() that holds the
> DAPM mutex.
So that's safe with regard to DAPM... it's not the specific example
that's concerning me here so much as the fact that I don't think we're
doing anything else to make sure shutdown is safe with other things that
might be going on when shutdown is called. There's probably a huge raft
of issues that might occur...
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-07-06 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 15:57 [PATCH] ASoC: dapm: Fix locking during codec shutdown Liam Girdwood
2012-07-06 16:02 ` Mark Brown
2012-07-06 16:36 ` Liam Girdwood
2012-07-06 16:43 ` Mark Brown
2012-07-06 17:10 ` Liam Girdwood
2012-07-06 17:20 ` Mark Brown [this message]
2012-07-06 18:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706172029.GI4017@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox