From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org,
linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too
Date: Tue, 31 Jul 2012 15:56:15 +0100 [thread overview]
Message-ID: <20120731145614.GZ4468@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1343745944-18418-2-git-send-email-lee.jones@linaro.org>
On Tue, Jul 31, 2012 at 03:45:40PM +0100, Lee Jones wrote:
> If a list of widgets is provided and one of them fails to be added as
> a control, the present semantics fail all subsequent widgets. A better
> solution would be to only fail that widget, but pursue in attempting
> to add the rest of the list.
To reiterate, this is in *no* way urgent or even a bug fix.
> dev_err(dapm->dev,
> "ASoC: Failed to create DAPM control %s\n",
> widget->name);
> - ret = -ENOMEM;
> - break;
Indeed, removing the error return is a regression.
next prev parent reply other threads:[~2012-07-31 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 14:45 [PATCH 0/6] Bugfixes and clean-ups bound for the v3.6 RCs Lee Jones
2012-07-31 14:45 ` [PATCH 1/5] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too Lee Jones
2012-07-31 14:56 ` Mark Brown [this message]
2012-07-31 15:09 ` Lee Jones
2012-07-31 15:15 ` Mark Brown
2012-07-31 14:45 ` [PATCH 2/5] ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements Lee Jones
2012-07-31 15:38 ` Mark Brown
2012-07-31 14:45 ` [PATCH 3/5] ARM: ux500: Remove unused snowball_of_platform_devs struct Lee Jones
2012-07-31 14:45 ` [PATCH 4/5] ARM: ux500: Fix merge error, so such struct 'snd_soc_u8500' Lee Jones
2012-07-31 14:45 ` [PATCH 5/5] ARM: ux500: Ensure probing of Audio devices when Device Tree is enabled Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731145614.GZ4468@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ola.o.lilja@stericsson.com \
--cc=olalilja@yahoo.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).