From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] Revert "ASoC: core: Try to use regmap if the driver doesn't set up any I/O"
Date: Wed, 1 Aug 2012 16:22:48 +0100 [thread overview]
Message-ID: <20120801152248.GZ11892@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1343829022-23259-1-git-send-email-peter.ujfalusi@ti.com>
On Wed, Aug 01, 2012 at 04:50:22PM +0300, Peter Ujfalusi wrote:
> Some codec driver can not have regmap implementation so core should not
> assume that codecs without control_data have implemented regmap of it's
> own.
>
> This reverts commit 38cbf9598feba97de9f9b43efa9153fd7c1a2ec9.
No, this isn't constructive - it just shoves things onto the drivers
that are relying on the implicit functionality. Why not just change the
criteria we use to check, for example looking for the ops instead?
next prev parent reply other threads:[~2012-08-01 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 13:50 [PATCH] Revert "ASoC: core: Try to use regmap if the driver doesn't set up any I/O" Peter Ujfalusi
2012-08-01 15:22 ` Mark Brown [this message]
2012-08-01 16:13 ` Takashi Iwai
2012-08-01 17:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801152248.GZ11892@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).