From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] Revert "ASoC: core: Try to use regmap if the driver doesn't set up any I/O"
Date: Wed, 1 Aug 2012 18:59:55 +0100 [thread overview]
Message-ID: <20120801175953.GA4483@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hzk6ed1zr.wl%tiwai@suse.de>
On Wed, Aug 01, 2012 at 06:13:28PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> > No, this isn't constructive - it just shoves things onto the drivers
> > that are relying on the implicit functionality. Why not just change the
> > criteria we use to check, for example looking for the ops instead?
> Well, the NULL check of dev_get_regmap() looks necessary, but I find
> it was done in a wrong place in Peter's first patch, too.
> It could be rather in the caller side, e.g.
Yes, this is exactly the sort of change I'm talking about above. We
need to take a better decision about deciding to use regmap for the
device I/O, this seems like a useful input. Checking for ops should be
even better, though - one could potentially use regmap but want to wrap
it for some reason (can't think of one right now though).
What I *don't* think is a good idea is trying to bodge this in the I/O
code.
prev parent reply other threads:[~2012-08-01 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 13:50 [PATCH] Revert "ASoC: core: Try to use regmap if the driver doesn't set up any I/O" Peter Ujfalusi
2012-08-01 15:22 ` Mark Brown
2012-08-01 16:13 ` Takashi Iwai
2012-08-01 17:59 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801175953.GA4483@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).