From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org,
linus.walleij@stericsson.com, arnd@arndb.de,
broonie@opensource.wolfsonmicro.com, olalilja@yahoo.se,
STEricsson_nomadik_linux@list.st.com, lrg@ti.com
Subject: Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too
Date: Thu, 2 Aug 2012 13:21:03 +0100 [thread overview]
Message-ID: <20120802122101.GA22228@gmail.com> (raw)
In-Reply-To: <1343741493-17671-3-git-send-email-lee.jones@linaro.org>
Patch withdrawn.
On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote:
> If a list of widgets is provided and one of them fails to be added as
> a control, the present semantics fail all subsequent widgets. A better
> solution would be to only fail that widget, but pursue in attempting
> to add the rest of the list.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> sound/soc/soc-dapm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> index eded657..7d9c154 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -3095,8 +3095,6 @@ int snd_soc_dapm_new_controls(struct snd_soc_dapm_context *dapm,
> dev_err(dapm->dev,
> "ASoC: Failed to create DAPM control %s\n",
> widget->name);
> - ret = -ENOMEM;
> - break;
> }
> widget++;
> }
> --
> 1.7.9.5
>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2012-08-02 12:21 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 13:31 [PATCH 1/6] Bugfixes and clean-ups bound for the v3.6 RCs Lee Jones
2012-07-31 13:31 ` [PATCH 1/6] ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements Lee Jones
2012-07-31 13:31 ` [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too Lee Jones
2012-07-31 13:42 ` Mark Brown
2012-07-31 14:25 ` Lee Jones
2012-07-31 14:28 ` Mark Brown
2012-07-31 14:38 ` Lee Jones
2012-07-31 14:54 ` Mark Brown
2012-07-31 15:15 ` Lee Jones
2012-07-31 15:18 ` Mark Brown
2012-08-01 7:19 ` Lee Jones
2012-08-01 13:20 ` Mark Brown
2012-08-01 13:50 ` Lee Jones
2012-08-01 16:08 ` Mark Brown
2012-08-01 19:41 ` Mark Brown
2012-08-02 7:45 ` [alsa-devel] " Lee Jones
2012-08-02 17:56 ` Mark Brown
2012-08-03 8:30 ` Lee Jones
2012-08-04 0:48 ` Mark Brown
2012-08-02 5:58 ` Ola Lilja
2012-08-02 9:59 ` Mark Brown
2012-08-10 11:43 ` Linus Walleij
2012-08-02 12:21 ` Lee Jones [this message]
2012-07-31 13:31 ` [PATCH 2/6] ARM: ux500: Remove unused snowball_of_platform_devs struct Lee Jones
2012-07-31 13:31 ` [PATCH 2/6] ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements Lee Jones
2012-07-31 13:31 ` [PATCH 3/6] ARM: ux500: Fix merge error, so such struct 'snd_soc_u8500' Lee Jones
2012-07-31 16:46 ` Sergei Shtylyov
2012-08-01 7:37 ` Lee Jones
2012-08-01 8:19 ` Lee Jones
2012-08-01 8:46 ` [PATCH 3/6 v2] ARM: ux500: Fix merge error, no matching driver name for, 'snd_soc_u8500' Lee Jones
2012-07-31 13:31 ` [PATCH 3/6] ARM: ux500: Remove unused snowball_of_platform_devs struct Lee Jones
2012-07-31 20:58 ` Arnd Bergmann
2012-07-31 13:31 ` [PATCH 4/6] ARM: ux500: Ensure probing of Audio devices when Device Tree is enabled Lee Jones
2012-07-31 13:31 ` [PATCH 4/6] ARM: ux500: Fix merge error, so such struct 'snd_soc_u8500' Lee Jones
2012-07-31 20:58 ` Arnd Bergmann
2012-07-31 13:31 ` [PATCH 5/6] ARM: ux500: Enable HIGHMEM on all mop500 platforms Lee Jones
2012-07-31 13:56 ` Russell King - ARM Linux
2012-07-31 14:29 ` Lee Jones
2012-07-31 14:37 ` Russell King - ARM Linux
2012-07-31 20:50 ` Arnd Bergmann
2012-07-31 22:01 ` Russell King - ARM Linux
2012-08-01 7:56 ` Lee Jones
2012-08-01 8:41 ` Russell King - ARM Linux
2012-08-01 8:48 ` Lee Jones
2012-07-31 13:31 ` [PATCH 5/6] ARM: ux500: Ensure probing of Audio devices when Device Tree is enabled Lee Jones
2012-07-31 20:54 ` Arnd Bergmann
2012-08-01 7:34 ` Lee Jones
2012-08-01 13:32 ` Arnd Bergmann
2012-08-01 13:55 ` Lee Jones
2012-08-01 14:32 ` Arnd Bergmann
2012-07-31 13:31 ` [PATCH 6/6] ARM: ux500: Enable HIGHMEM on all mop500 platforms Lee Jones
2012-07-31 13:31 ` [PATCH 6/6] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver Lee Jones
2012-07-31 13:40 ` [PATCH 1/6] Bugfixes and clean-ups bound for the v3.6 RCs Mark Brown
2012-07-31 14:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802122101.GA22228@gmail.com \
--to=lee.jones@linaro.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=ola.o.lilja@stericsson.com \
--cc=olalilja@yahoo.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).