From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Scott Jiang <scott.jiang.linux@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: ad1836: convert to use snd_soc_register_card
Date: Thu, 9 Aug 2012 14:08:41 +0100 [thread overview]
Message-ID: <20120809130841.GS24328@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1344550120-30901-1-git-send-email-scott.jiang.linux@gmail.com>
On Thu, Aug 09, 2012 at 06:08:39PM -0400, Scott Jiang wrote:
> Cpu dai and codec name are passed in through platform data.
Won't applying this break all existing boards - there's no patch adding
platform data here? We should merge the updates for the boards together
with the driver update to ensure they still work, or provide default
platform data so that only boards that wish to change something from the
current code need to be updated.
Also, the patch description should be something like "ASoC: bf5xx-ad1836"
as it's a board driver change.
next prev parent reply other threads:[~2012-08-09 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 22:08 [PATCH 1/2] ASoC: ad1836: convert to use snd_soc_register_card Scott Jiang
2012-08-09 13:08 ` Mark Brown [this message]
2012-08-09 22:08 ` [PATCH 2/2] ASoC: bfin: fix memory leak in sport3 controller driver Scott Jiang
2012-08-09 13:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809130841.GS24328@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=scott.jiang.linux@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).