* [PATCH][trivial] ASoC: isabelle: Remove unneeded include of version.h
@ 2012-08-10 18:12 Jesper Juhl
2012-08-10 18:16 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Jesper Juhl @ 2012-08-10 18:12 UTC (permalink / raw)
To: linux-kernel
Cc: alsa-devel, trivial, Takashi Iwai, Mark Brown,
Vishwas A Deshpande, M R Swami Reddy, Liam Girdwood
There is no need to include version.h in sound/soc/codecs/isabelle.c -
this patch removes the pointless include.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
sound/soc/codecs/isabelle.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/isabelle.c b/sound/soc/codecs/isabelle.c
index 5d8f39e..1bf5560 100644
--- a/sound/soc/codecs/isabelle.c
+++ b/sound/soc/codecs/isabelle.c
@@ -13,7 +13,6 @@
*/
#include <linux/module.h>
#include <linux/moduleparam.h>
-#include <linux/version.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/delay.h>
--
1.7.11.4
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][trivial] ASoC: isabelle: Remove unneeded include of version.h
2012-08-10 18:12 [PATCH][trivial] ASoC: isabelle: Remove unneeded include of version.h Jesper Juhl
@ 2012-08-10 18:16 ` Mark Brown
2012-08-10 18:21 ` Jesper Juhl
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2012-08-10 18:16 UTC (permalink / raw)
To: Jesper Juhl
Cc: alsa-devel, trivial, Takashi Iwai, linux-kernel,
Vishwas A Deshpande, M R Swami Reddy, Liam Girdwood
On Fri, Aug 10, 2012 at 08:12:57PM +0200, Jesper Juhl wrote:
> There is no need to include version.h in sound/soc/codecs/isabelle.c -
> this patch removes the pointless include.
Not sure what this patch is against, there appears to be no include of
version.h in current code...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trivial] ASoC: isabelle: Remove unneeded include of version.h
2012-08-10 18:16 ` Mark Brown
@ 2012-08-10 18:21 ` Jesper Juhl
2012-08-10 18:24 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Jesper Juhl @ 2012-08-10 18:21 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, trivial, Takashi Iwai, linux-kernel,
Vishwas A Deshpande, M R Swami Reddy, Liam Girdwood
On Fri, 10 Aug 2012, Mark Brown wrote:
> On Fri, Aug 10, 2012 at 08:12:57PM +0200, Jesper Juhl wrote:
> > There is no need to include version.h in sound/soc/codecs/isabelle.c -
> > this patch removes the pointless include.
>
> Not sure what this patch is against, there appears to be no include of
> version.h in current code...
It's against Linus's tree. I created a branch off of master at
f4ba394c1b02e7fc2179fda8d3941a5b3b65efb6 and did the patch.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trivial] ASoC: isabelle: Remove unneeded include of version.h
2012-08-10 18:21 ` Jesper Juhl
@ 2012-08-10 18:24 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-08-10 18:24 UTC (permalink / raw)
To: Jesper Juhl
Cc: alsa-devel, trivial, Takashi Iwai, linux-kernel,
Vishwas A Deshpande, M R Swami Reddy, Liam Girdwood
On Fri, Aug 10, 2012 at 08:21:51PM +0200, Jesper Juhl wrote:
> On Fri, 10 Aug 2012, Mark Brown wrote:
> > Not sure what this patch is against, there appears to be no include of
> > version.h in current code...
> It's against Linus's tree. I created a branch off of master at
> f4ba394c1b02e7fc2179fda8d3941a5b3b65efb6 and did the patch.
Ah, the fix is only in -next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-10 17:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-10 18:12 [PATCH][trivial] ASoC: isabelle: Remove unneeded include of version.h Jesper Juhl
2012-08-10 18:16 ` Mark Brown
2012-08-10 18:21 ` Jesper Juhl
2012-08-10 18:24 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).