[PATCH] sound: tegra_alc5632: remove HP detect GPIO inversion

[PATCH] sound: tegra_alc5632: remove HP detect GPIO inversion

[Stephen Warren]

From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Both the schematics and practical testing show that the HP detect GPIO
is high when the headphones are plugged in. Hence, the snd_soc_jack_gpio
should not specify to invert the signal.

Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Cc: Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>
Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # v3.4 v3.5
---
 sound/soc/tegra/tegra_alc5632.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c
index e463529..76cb1b3 100644
--- a/sound/soc/tegra/tegra_alc5632.c
+++ b/sound/soc/tegra/tegra_alc5632.c
@@ -89,7 +89,6 @@ static struct snd_soc_jack_gpio tegra_alc5632_hp_jack_gpio = {
 	.name = "Headset detection",
 	.report = SND_JACK_HEADSET,
 	.debounce_time = 150,
-	.invert = 1,
 };
 
 static const struct snd_soc_dapm_widget tegra_alc5632_dapm_widgets[] = {
-- 
1.7.9.5

Re: [PATCH] sound: tegra_alc5632: remove HP detect GPIO inversion

[Marc Dietrich]

Hi Stephen,

On Friday 24 August 2012 21:20:15 Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Both the schematics and practical testing show that the HP detect GPIO
> is high when the headphones are plugged in. Hence, the snd_soc_jack_gpio
> should not specify to invert the signal.
> 
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Cc: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
> Cc: Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # v3.4 v3.5

I tested it and evtest gives back the right stuff with your patch. Can't test 
more because I have no headphone/mic here (I just inserted a screwdriver, 
grr). On 3.1 kernels, we also have no pin inversion, so unless Leon or Andrey 
(cc'ed) have different opinions, this can go through. Just give them a week...

Thanks!

Marc

> ---
>  sound/soc/tegra/tegra_alc5632.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/tegra/tegra_alc5632.c
> b/sound/soc/tegra/tegra_alc5632.c index e463529..76cb1b3 100644
> --- a/sound/soc/tegra/tegra_alc5632.c
> +++ b/sound/soc/tegra/tegra_alc5632.c
> @@ -89,7 +89,6 @@ static struct snd_soc_jack_gpio tegra_alc5632_hp_jack_gpio
> = { .name = "Headset detection",
>  	.report = SND_JACK_HEADSET,
>  	.debounce_time = 150,
> -	.invert = 1,
>  };
> 
>  static const struct snd_soc_dapm_widget tegra_alc5632_dapm_widgets[] = {

Re: [PATCH] sound: tegra_alc5632: remove HP detect GPIO inversion

[Andrey Danin]

Fri, 24 Aug 2012 21:20:15 -0600 от Stephen Warren <swarren@wwwdotorg.org>:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Both the schematics and practical testing show that the HP detect GPIO
> is high when the headphones are plugged in. Hence, the snd_soc_jack_gpio
> should not specify to invert the signal.
> 

Acked-by: Andrey Danin <danindrey@mail.ru>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] sound: tegra_alc5632: remove HP detect GPIO inversion

[Mark Brown]

On Fri, Aug 24, 2012 at 09:20:15PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Both the schematics and practical testing show that the HP detect GPIO
> is high when the headphones are plugged in. Hence, the snd_soc_jack_gpio
> should not specify to invert the signal.

Applied, thanks.