From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: ams-delta: fix card initalization failure
Date: Fri, 31 Aug 2012 14:31:04 -0700 [thread overview]
Message-ID: <20120831213103.GC5495@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1809544.cvZPIRmRr5@acer>
On Wed, Aug 29, 2012 at 07:04:48AM +0200, Janusz Krzysztofik wrote:
> On Tue, 28 Aug 2012 11:13:39 Mark Brown wrote:
> > The above looks like you already have a platform driver? All I'm
> > suggesting is changing the above to use platform rather than driver
> > data.
> The ams-delta asoc driver doesn't use snd_soc_register_card() so far,
> but relays solely on soc_probe() doing this for it, which in turn
> expects to find a snc_soc_card structure in drvdata. How is it supposed
> to find that structure if I pass it over platform data instead? Am I
> missing something?
s/drvdata/platdata/ in the code. If you can't do this then just
referencing the data directly in the code would be better than this
bodge, it'd be much less fragile.
next prev parent reply other threads:[~2012-08-31 21:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 21:28 [PATCH] ASoC: ams-delta: fix card initalization failure Janusz Krzysztofik
2012-08-27 21:38 ` Mark Brown
2012-08-28 15:13 ` Janusz Krzysztofik
2012-08-28 18:13 ` Mark Brown
2012-08-29 5:04 ` [alsa-devel] " Janusz Krzysztofik
2012-08-31 21:31 ` Mark Brown [this message]
2012-09-01 9:09 ` Janusz Krzysztofik
2012-09-06 7:36 ` [alsa-devel] " Mark Brown
2012-09-16 19:17 ` [PATCH] ASoC: ams-delta: Convert to use snd_soc_register_card() Janusz Krzysztofik
2012-09-16 20:44 ` Tony Lindgren
2012-10-02 21:07 ` Janusz Krzysztofik
2012-10-03 10:38 ` Mark Brown
2012-10-03 10:46 ` [RESEND][PATCH] " Janusz Krzysztofik
2012-10-03 13:51 ` Janusz Krzysztofik
2012-10-04 17:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120831213103.GC5495@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).