* Re: [PATCH] ASoC: mc13783: Remove mono support
[not found] <1346688253-29047-1-git-send-email-fabio.estevam@freescale.com>
@ 2012-09-04 7:10 ` Gaëtan Carlier
2012-09-06 0:17 ` Mark Brown
1 sibling, 0 replies; 2+ messages in thread
From: Gaëtan Carlier @ 2012-09-04 7:10 UTC (permalink / raw)
To: Fabio Estevam; +Cc: philippe.retornaz, alsa-devel, broonie, kernel
Hi,
On 09/03/2012 06:04 PM, Fabio Estevam wrote:
> Playing a mono track on a mc13783 codec results in incorrect playback rate.
>
> Remove mono support so that a mono track can be played correctly.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> sound/soc/codecs/mc13783.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c
> index 8f726c0..115a403 100644
> --- a/sound/soc/codecs/mc13783.c
> +++ b/sound/soc/codecs/mc13783.c
> @@ -659,7 +659,7 @@ static struct snd_soc_dai_driver mc13783_dai_async[] = {
> .id = MC13783_ID_STEREO_DAC,
> .playback = {
> .stream_name = "Playback",
> - .channels_min = 1,
> + .channels_min = 2,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = MC13783_FORMATS,
> @@ -670,7 +670,7 @@ static struct snd_soc_dai_driver mc13783_dai_async[] = {
> .id = MC13783_ID_STEREO_CODEC,
> .capture = {
> .stream_name = "Capture",
> - .channels_min = 1,
> + .channels_min = 2,
> .channels_max = 2,
> .rates = MC13783_RATES_RECORD,
> .formats = MC13783_FORMATS,
> @@ -692,14 +692,14 @@ static struct snd_soc_dai_driver mc13783_dai_sync[] = {
> .id = MC13783_ID_SYNC,
> .playback = {
> .stream_name = "Playback",
> - .channels_min = 1,
> + .channels_min = 2,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = MC13783_FORMATS,
> },
> .capture = {
> .stream_name = "Capture",
> - .channels_min = 1,
> + .channels_min = 2,
> .channels_max = 2,
> .rates = MC13783_RATES_RECORD,
> .formats = MC13783_FORMATS,
>
On imx27_3ds board:
Tested-by: Gaëtan Carlier <gcembed@gmail.com>
Regards,
Gaëtan Carlier
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: mc13783: Remove mono support
[not found] <1346688253-29047-1-git-send-email-fabio.estevam@freescale.com>
2012-09-04 7:10 ` [PATCH] ASoC: mc13783: Remove mono support Gaëtan Carlier
@ 2012-09-06 0:17 ` Mark Brown
1 sibling, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-09-06 0:17 UTC (permalink / raw)
To: Fabio Estevam; +Cc: philippe.retornaz, alsa-devel, kernel, gcembed
On Mon, Sep 03, 2012 at 01:04:13PM -0300, Fabio Estevam wrote:
> Playing a mono track on a mc13783 codec results in incorrect playback rate.
>
> Remove mono support so that a mono track can be played correctly.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-06 0:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1346688253-29047-1-git-send-email-fabio.estevam@freescale.com>
2012-09-04 7:10 ` [PATCH] ASoC: mc13783: Remove mono support Gaëtan Carlier
2012-09-06 0:17 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).