[PATCH -next] soc: fix wm0010.c printk format warning

[PATCH -next] soc: fix wm0010.c printk format warning

[Randy Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Fix printk format warning:

sound/soc/codecs/wm0010.c:411:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
---
 sound/soc/codecs/wm0010.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20120905.orig/sound/soc/codecs/wm0010.c
+++ linux-next-20120905/sound/soc/codecs/wm0010.c
@@ -408,7 +408,7 @@ static int wm0010_boot(struct snd_soc_co
 	wm0010->state = WM0010_BOOTROM;
 	spin_unlock_irqrestore(&wm0010->irq_lock, flags);
 
-	dev_dbg(codec->dev, "Downloading %d byte stage 2 loader\n", fw->size);
+	dev_dbg(codec->dev, "Downloading %zu byte stage 2 loader\n", fw->size);
 
 	/* Copy to local buffer first as vmalloc causes problems for dma */
 	img = kzalloc(fw->size, GFP_KERNEL);

Re: [PATCH -next] soc: fix wm0010.c printk format warning

[Mark Brown]

On Wed, Sep 05, 2012 at 04:24:57PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix printk format warning:

Somone already sent this.  As ever please try to use subject lines
appropriate for the subsystem.  Please also consider who you're CCing -
there's no need to copy -next on things like this which aren't
integration issues for example, if we start doing that then it'd get
drowned in noise from all the development.

Re: [PATCH -next] soc: fix wm0010.c printk format warning

[Randy Dunlap]

On 09/05/2012 05:06 PM, Mark Brown wrote:

> On Wed, Sep 05, 2012 at 04:24:57PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> Fix printk format warning:
> 
> Somone already sent this.  As ever please try to use subject lines
> appropriate for the subsystem.  Please also consider who you're CCing -


Unfortunately the MAINTAINERS file does not tell me what to include
in the $subject line for the subsystem.
What would you like to see there, please?  Maybe ASoC?

> there's no need to copy -next on things like this which aren't


I have always done a reply-to-all for linux-next patches, so after
a few years someone days Don't Do That (IYO).

> integration issues for example, if we start doing that then it'd get
> drowned in noise from all the development.


Agreed, many of us are already drowning from 1000+ emails per day.
(seriously)

-- 
~Randy

Re: [PATCH -next] soc: fix wm0010.c printk format warning

[Sedat Dilek]

On Thu, Sep 6, 2012 at 2:11 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On 09/05/2012 05:06 PM, Mark Brown wrote:
>
>> On Wed, Sep 05, 2012 at 04:24:57PM -0700, Randy Dunlap wrote:
>>> From: Randy Dunlap <rdunlap@xenotime.net>
>>>
>>> Fix printk format warning:
>>
>> Somone already sent this.  As ever please try to use subject lines
>> appropriate for the subsystem.  Please also consider who you're CCing -
>
>
> Unfortunately the MAINTAINERS file does not tell me what to include
> in the $subject line for the subsystem.
> What would you like to see there, please?  Maybe ASoC?
>

git log --oneline sound/soc/codecs/wm0010.c

Label looks like "ASoC: wm0010:"... (ASoC kills my shift key, I would
like to see all labels lower-case).

>> there's no need to copy -next on things like this which aren't
>
>
> I have always done a reply-to-all for linux-next patches, so after
> a few years someone days Don't Do That (IYO).
>

Then maintainers should check compiler-warnings in their area - regularly?

$ grep warning: v3.6.0-rc4-next20120905-1-iniza-generic/deb-pkg.log |
grep 'sound/soc' | wc -l
10

I agree that breakage and regressions should be dealt with higher
priority... Such patches like this should be welcome, anyway.

>> integration issues for example, if we start doing that then it'd get
>> drowned in noise from all the development.
>
>
> Agreed, many of us are already drowning from 1000+ emails per day.
> (seriously)
>

Spam will one day eliminate Email, it's perverted.

- Sedat -

> --
> ~Randy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] soc: fix wm0010.c printk format warning

[Mark Brown]

On Wed, Sep 05, 2012 at 05:11:08PM -0700, Randy Dunlap wrote:
> On 09/05/2012 05:06 PM, Mark Brown wrote:

> > Somone already sent this.  As ever please try to use subject lines
> > appropriate for the subsystem.  Please also consider who you're CCing -

> Unfortunately the MAINTAINERS file does not tell me what to include
> in the $subject line for the subsystem.
> What would you like to see there, please?  Maybe ASoC?

As with every other subsystem in the kernel look at the log for the
thing your changing and do something that visually resembles it.  If you
want get_maintainers to do this for you you'll need to write the code
(or convince someone else to do it).

> > there's no need to copy -next on things like this which aren't

> I have always done a reply-to-all for linux-next patches, so after
> a few years someone days Don't Do That (IYO).

I'm pretty sure I've mentioned this before...  actually, if you're
relying on get_maintainers that's probably some of the false positives
too.  If you've found an issue related to the -next integration that's
one thing but if you've just noticed a random thing in the kernel that
could be improved that's not really something about -next.