From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Arnd Bergmann <arnd@arndb.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <rob.herring@calxeda.com>,
Javier Martin <javier.martin@vista-silicon.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/34] ASoC: mx27vis: retrieve gpio numbers from platform_data
Date: Mon, 17 Sep 2012 07:07:42 -0400 [thread overview]
Message-ID: <20120917110741.GD5401@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347860103-4141-3-git-send-email-shawn.guo@linaro.org>
On Mon, Sep 17, 2012 at 01:34:31PM +0800, Shawn Guo wrote:
I've applied this since Javier says it fixes a bug but I'm not terribly
enthused about it.
> arch/arm/mach-imx/mach-imx27_visstrim_m10.c | 42 ++++++++++++++++++++++++++-
> include/linux/platform_data/asoc-mx27vis.h | 11 +++++++
> sound/soc/fsl/mx27vis-aic32x4.c | 42 +++++++++++++--------------
Audio drivers put their platform data in include/sound.
> 3 files changed, 72 insertions(+), 23 deletions(-)
This also seems like we're just going to be going for bloat, given that
this is a general change we should be (finally) getting round to having
a generic GPIO based CODEC driver.
next prev parent reply other threads:[~2012-09-17 11:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 5:34 [PATCH 00/34] i.MX multi-platform support Shawn Guo
2012-09-17 5:34 ` [PATCH 02/34] ASoC: mx27vis: retrieve gpio numbers from platform_data Shawn Guo
2012-09-17 9:19 ` javier Martin
2012-09-17 11:07 ` Mark Brown [this message]
2012-09-20 1:14 ` Shawn Guo
2012-09-20 1:26 ` Mark Brown
2012-09-20 2:20 ` Shawn Guo
2012-09-17 5:34 ` [PATCH 16/34] ASoC: imx-ssi: remove unneeded mach/hardware.h inclusion Shawn Guo
2012-09-17 11:45 ` Mark Brown
2012-09-17 14:30 ` Arnd Bergmann
2012-09-19 3:23 ` Mark Brown
2012-09-19 8:01 ` Arnd Bergmann
2012-09-19 11:44 ` Mark Brown
2012-09-17 5:35 ` [PATCH 33/34] ARM: imx: remove header file mach/irqs.h Shawn Guo
2012-09-17 11:32 ` Arnd Bergmann
2012-09-18 8:13 ` Shawn Guo
2012-09-17 11:46 ` Mark Brown
2012-09-17 7:51 ` [PATCH 00/34] i.MX multi-platform support Sascha Hauer
2012-09-17 11:38 ` Arnd Bergmann
2012-09-18 8:20 ` Shawn Guo
2012-09-18 7:52 ` Sascha Hauer
2012-09-18 8:05 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120917110741.GD5401@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=fabio.estevam@freescale.com \
--cc=javier.martin@vista-silicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).