From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Richard Zhao <richard.zhao@freescale.com>
Cc: alsa-devel@alsa-project.org, shawn.guo@linaro.org,
s.hauer@pengutronix.de, lrg@ti.com
Subject: Re: [PATCH] ASoC: imx-audmux: remove null check of audmux_base in audmux_read_file
Date: Tue, 18 Sep 2012 22:53:47 -0400 [thread overview]
Message-ID: <20120919025345.GL8832@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347957510-20590-1-git-send-email-richard.zhao@freescale.com>
On Tue, Sep 18, 2012 at 04:38:30PM +0800, Richard Zhao wrote:
> When audmux_read_file is called, it means the driver is already
> initialised successfully, so we don't need to check audmux_base.
>
> It also fix smatch warning:
> sound/soc/fsl/imx-audmux.c:78 audmux_read_file() warn: possible memory leak of 'buf'
Applied, though it doesn't seem like the best fix to remove an error
check even if it should be redundant.
prev parent reply other threads:[~2012-09-19 2:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 8:38 [PATCH] ASoC: imx-audmux: remove null check of audmux_base in audmux_read_file Richard Zhao
2012-09-19 2:53 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919025345.GL8832@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=richard.zhao@freescale.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).