From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
alsa-devel <alsa-devel@alsa-project.org>, lrg <lrg@ti.com>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH v2] ASoC: codecs: Add DA9055 codec driver
Date: Thu, 20 Sep 2012 07:59:10 -0400 [thread overview]
Message-ID: <20120920115908.GL17666@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1348142335.18996.17.camel@matrix>
On Thu, Sep 20, 2012 at 05:28:55PM +0530, Ashish Chavan wrote:
> > > + /* To select if MIC Bias powers MIC 1 or MIC 2 */
> > > + SOC_ENUM("Mic Bias Select", da9055_mic_bias_select),
> > This would normally be something controlled by the board... what
> > exactly is this doing? How does the MICBIAS relate to the microphone
> > inputs?
> Yes, it should be controlled by the board.
> This control selects which of the two MIC Bias pins acts as the BIAS
> source. Earlier we misinterpreted it because of a hardware modification
> which was present on the board without our knowledge.
OK, that sounds like it should either be hooked up in the DAPM graph
or supplied as platform data then.
> > Given that there's no regulator support here
> > it's also a bit surprising that you need to do a sync outside of system
> > suspend...
> I am not sure if I understood this fully. Do you mean a sync is not
> required here?
You only need to resync if the device might have lost power and
forgotten it's register settings (or might've forgotten them for some
other reason). If the device is left powered up then this isn't needed.
prev parent reply other threads:[~2012-09-20 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 11:27 [PATCH v2] ASoC: codecs: Add DA9055 codec driver Ashish Chavan
2012-09-19 2:50 ` Mark Brown
2012-09-20 11:58 ` Ashish Chavan
2012-09-20 11:59 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920115908.GL17666@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).