From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: core: Configure pin muxing via pinctrl when registering a DAI
Date: Fri, 21 Sep 2012 07:13:53 -0400 [thread overview]
Message-ID: <20120921111352.GA21524@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1348214066-28384-1-git-send-email-peter.ujfalusi@ti.com>
On Fri, Sep 21, 2012 at 10:54:26AM +0300, Peter Ujfalusi wrote:
> pinctrl framework now becoming widely available for SoCs to configure pin
> multiplexing.
> Instead of adding the same code to all dai drivers the core can take care
> of this transparently.
> Do not make too much noise if pinctrl is not provided via DT for the dai
> but just use dev_info().
Please fix your word wrapping, I've mentioned this to you before...
> +/*
> + * Simple function to be used in snd_soc_dai_register_dai/s to set the default
> + * pinmuxing for the dai.
I would be more inclined to do this on card init time, doing it at
registration seems wrong as systems typically have interfaces that
aren't used and share pins with other functions. By the time we are
setting up a card we've got a good idea we actually want to use the IP
but at probe time that's not the case.
It also seems bad that we're ignoring errors, does the pinctl API not
stub itself out well enough.
next prev parent reply other threads:[~2012-09-21 11:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 7:54 [PATCH] ASoC: core: Configure pin muxing via pinctrl when registering a DAI Peter Ujfalusi
2012-09-21 11:13 ` Mark Brown [this message]
2012-09-21 13:16 ` Peter Ujfalusi
2012-09-21 14:55 ` Peter Ujfalusi
2012-09-22 15:23 ` Mark Brown
2012-09-21 16:23 ` Stephen Warren
2012-09-22 15:28 ` Mark Brown
2012-09-23 3:23 ` Stephen Warren
2012-09-24 9:20 ` Linus Walleij
2012-09-24 10:17 ` Mark Brown
2012-09-24 14:37 ` Linus Walleij
2012-09-25 11:11 ` Mark Brown
2012-09-25 11:24 ` Peter Ujfalusi
2012-09-25 11:43 ` Linus Walleij
2012-09-25 11:43 ` Mark Brown
2012-09-25 11:56 ` Linus Walleij
2012-09-25 12:24 ` Mark Brown
2012-09-25 17:00 ` Stephen Warren
2012-09-24 15:41 ` Stephen Warren
2012-09-25 11:22 ` Mark Brown
2012-09-24 8:34 ` Linus Walleij
2012-09-24 10:23 ` Mark Brown
2012-09-24 15:38 ` Stephen Warren
2012-09-22 15:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921111352.GA21524@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).