From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: core: Configure pin muxing via pinctrl when registering a DAI Date: Tue, 25 Sep 2012 07:11:47 -0400 Message-ID: <20120925111146.GC4428@opensource.wolfsonmicro.com> References: <1348214066-28384-1-git-send-email-peter.ujfalusi@ti.com> <20120921111352.GA21524@opensource.wolfsonmicro.com> <505C68AA.7080907@ti.com> <505C9496.1050307@wwwdotorg.org> <20120922152840.GM4495@opensource.wolfsonmicro.com> <505E80AD.9050000@wwwdotorg.org> <20120924101757.GC21375@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 8C30D260744 for ; Tue, 25 Sep 2012 13:11:48 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Linus Walleij Cc: Peter Ujfalusi , alsa-devel@alsa-project.org, Liam Girdwood , Stephen Warren List-Id: alsa-devel@alsa-project.org On Mon, Sep 24, 2012 at 04:37:23PM +0200, Linus Walleij wrote: > On Mon, Sep 24, 2012 at 12:17 PM, Mark Brown > > Well, the problem here is that people keep wanting to add one shot > > pinctrl calls in drivers which clearly suggests that it ought to be > > factored out. > OK so can we find some suitable middle ground here? > Something like drivers could add some boolean flag to > "opt-in" for the core to handle this or so? Well, I don't know if we need to - it sounds like the platforms that are running around adding these pinctrl calls to all the drivers are doing it wrong and should be fixed. > After all only some MMC drivers call up to > mmc_regulator_set_ocr() to set voltages, it's optional > but centralized. This is mostly a historical thing, though - pinctrl is new.