* Re: ASoC: dapm: Allow regulators to bypass as well as disable when idle
@ 2012-09-27 19:57 Dan Carpenter
2012-09-28 10:42 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-09-27 19:57 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel
Hi Mark,
I had a question about patch c05b84d14b23: "ASoC: dapm: Allow regulators
to bypass as well as disable when idle" from Sep 7, 2012.
1022 if (SND_SOC_DAPM_EVENT_ON(event)) {
1023 if (w->invert & SND_SOC_DAPM_REGULATOR_BYPASS) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1024 ret = regulator_allow_bypass(w->regulator, true);
1025 if (ret != 0)
1026 dev_warn(w->dapm->dev,
1027 "Failed to bypass %s: %d\n",
1028 w->name, ret);
1029 }
1030
1031 return regulator_enable(w->regulator);
1032 } else {
1033 if (w->invert & SND_SOC_DAPM_REGULATOR_BYPASS) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Right now ->invert is a single bit bitfield. We mostly test
"if (w->invert) {...". Are we planning to add some more bits in there?
1034 ret = regulator_allow_bypass(w->regulator, false);
1035 if (ret != 0)
1036 dev_warn(w->dapm->dev,
1037 "Failed to unbypass %s: %d\n",
1038 w->name, ret);
1039 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-28 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-27 19:57 ASoC: dapm: Allow regulators to bypass as well as disable when idle Dan Carpenter
2012-09-28 10:42 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).