* [PATCH] ASoC: Revert 'ASoC: imx-ssi: Remove mono support'
@ 2012-09-06 0:30 Fabio Estevam
2012-09-06 0:44 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2012-09-06 0:30 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel, Javier Martin
From: Javier Martin <javier.martin@vista-silicon.com>
Revert 0865a75(ASoC: imx-ssi: Remove mono support).
The bug this patch is meant to solve doesn't occur in Visstrim_M10 boards.
Furthermore, after applying this patch sound in Visstrim_M10 is played
at slower rates.
Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
---
sound/soc/fsl/imx-ssi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
index 7074ae6..3c520c4 100644
--- a/sound/soc/fsl/imx-ssi.c
+++ b/sound/soc/fsl/imx-ssi.c
@@ -380,14 +380,13 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai)
static struct snd_soc_dai_driver imx_ssi_dai = {
.probe = imx_ssi_dai_probe,
.playback = {
- /* The SSI does not support monaural audio. */
- .channels_min = 2,
+ .channels_min = 1,
.channels_max = 2,
.rates = SNDRV_PCM_RATE_8000_96000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.capture = {
- .channels_min = 2,
+ .channels_min = 1,
.channels_max = 2,
.rates = SNDRV_PCM_RATE_8000_96000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Revert 'ASoC: imx-ssi: Remove mono support'
2012-09-06 0:30 [PATCH] ASoC: Revert 'ASoC: imx-ssi: Remove mono support' Fabio Estevam
@ 2012-09-06 0:44 ` Mark Brown
[not found] ` <CACKLOr3VDxDQb30aqNOhEHtc7AAFUZw07_BAwrk3yXqmBfHyxQ@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-09-06 0:44 UTC (permalink / raw)
To: Fabio Estevam; +Cc: alsa-devel, Javier Martin
On Wed, Sep 05, 2012 at 09:30:10PM -0300, Fabio Estevam wrote:
> From: Javier Martin <javier.martin@vista-silicon.com>
>
> Revert 0865a75(ASoC: imx-ssi: Remove mono support).
>
> The bug this patch is meant to solve doesn't occur in Visstrim_M10 boards.
> Furthermore, after applying this patch sound in Visstrim_M10 is played
> at slower rates.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Revert 'ASoC: imx-ssi: Remove mono support'
[not found] ` <CACKLOr3VDxDQb30aqNOhEHtc7AAFUZw07_BAwrk3yXqmBfHyxQ@mail.gmail.com>
@ 2012-10-01 12:20 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-10-01 12:20 UTC (permalink / raw)
To: javier Martin; +Cc: alsa-devel, Fabio Estevam
On Mon, Oct 01, 2012 at 11:33:45AM +0200, javier Martin wrote:
> Hi Mark, Fabio,
> this patch should be applied as a fix to stable 3.6 too. Otherwise,
> audio for Visstrim M10 will continue broken in 3.6.
You need to tell the stable team about this, then.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-01 12:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-06 0:30 [PATCH] ASoC: Revert 'ASoC: imx-ssi: Remove mono support' Fabio Estevam
2012-09-06 0:44 ` Mark Brown
[not found] ` <CACKLOr3VDxDQb30aqNOhEHtc7AAFUZw07_BAwrk3yXqmBfHyxQ@mail.gmail.com>
2012-10-01 12:20 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).