alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tim Gardner <tim.gardner@canonical.com>,
	linux-kernel@vger.kernel.org,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	linux-omap@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 3.7-rc1] omap zoom2.c: Fix compile error by including correct header files
Date: Wed, 3 Oct 2012 08:59:01 -0700	[thread overview]
Message-ID: <20121003155900.GA4840@atomide.com> (raw)
In-Reply-To: <506C5124.3050200@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [121003 07:52]:
> On 10/03/2012 05:31 PM, Tim Gardner wrote:
> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
> > Cc: Liam Girdwood <lrg@ti.com>
> > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > Cc: Jaroslav Kysela <perex@perex.cz>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Cc: linux-omap@vger.kernel.org
> > Cc: alsa-devel@alsa-project.org
> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> > ---
> >  sound/soc/omap/zoom2.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/sound/soc/omap/zoom2.c b/sound/soc/omap/zoom2.c
> > index 23de2b2..d0a8c92 100644
> > --- a/sound/soc/omap/zoom2.c
> > +++ b/sound/soc/omap/zoom2.c
> > @@ -27,9 +27,10 @@
> >  
> >  #include <asm/mach-types.h>
> >  #include <mach/hardware.h>
> > -#include <mach/gpio.h>
> > +#include <linux/gpio.h>
> >  #include <mach/board-zoom.h>
> >  #include <linux/platform_data/asoc-ti-mcbsp.h>
> > +#include <linux/platform_data/gpio-omap.h>
> >  
> >  /* Register descriptions for twl4030 codec part */
> >  #include <linux/mfd/twl4030-audio.h>
> > 
> 
> I have the same patch stashed away for the same issue. Was waiting for rc1 to
> send it.

Can you please update the patch to also to remove the
"#include <mach/board-zoom.h>" while at it?

AFAIK it's not needed at all and just adds a dependency to asoc with
my upcoming plat header cleanup patches.

Regards,

Tony

  reply	other threads:[~2012-10-03 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-03 14:31 [PATCH 3.7-rc1] omap zoom2.c: Fix compile error by including correct header files Tim Gardner
2012-10-03 14:52 ` Peter Ujfalusi
2012-10-03 15:59   ` Tony Lindgren [this message]
2012-10-03 16:31     ` Tony Lindgren
2012-10-27 21:44       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121003155900.GA4840@atomide.com \
    --to=tony@atomide.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@ti.com \
    --cc=tim.gardner@canonical.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).