From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Mack <zonque@gmail.com>
Cc: Matt Porter <mporter@ti.com>,
alsa-devel@alsa-project.org, lrg@ti.com, "Hebbar,
Gururaja" <gururaja.hebbar@ti.com>
Subject: Re: [PATCH 3/5] ALSA: ASoC: McASP: add support for 24 bit samples
Date: Tue, 9 Oct 2012 16:17:57 +0900 [thread overview]
Message-ID: <20121009071755.GX8237@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1349356122-14794-4-git-send-email-zonque@gmail.com>
On Thu, Oct 04, 2012 at 03:08:40PM +0200, Daniel Mack wrote:
> + case SNDRV_PCM_FORMAT_U24_3LE:
> + case SNDRV_PCM_FORMAT_S24_3LE:
> + case SNDRV_PCM_FORMAT_U24_LE:
> + case SNDRV_PCM_FORMAT_S24_LE:
> + dma_params->data_type = 3;
> + word_length = DAVINCI_AUDIO_WORD_24;
> + break;
> +
This is fine but should be adding the format to the set of supported
formats in the DAI as well, otherwise userspace should never select 24
bits.
next prev parent reply other threads:[~2012-10-09 7:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 13:08 [PATCH 0/5] McASP changes for more flexibility Daniel Mack
2012-10-04 13:08 ` [PATCH 1/5] ALSA: ASoC: enable 192KHz support for McASP Daniel Mack
2012-10-09 7:19 ` Mark Brown
2012-10-04 13:08 ` [PATCH 2/5] ALSA: ASoC: McASP: add support for clock dividers Daniel Mack
2012-10-04 13:08 ` [PATCH 3/5] ALSA: ASoC: McASP: add support for 24 bit samples Daniel Mack
2012-10-09 7:17 ` Mark Brown [this message]
2012-10-09 7:30 ` Daniel Mack
2012-10-04 13:08 ` [PATCH 4/5] ALSA: ASoC: McASP: make AHCLK direction configurable Daniel Mack
2012-10-09 7:21 ` Mark Brown
2012-10-04 13:08 ` [PATCH 5/5] ALSA: ASoC: McASP: set format parameters in dependence of the DAI format Daniel Mack
2012-10-09 7:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009071755.GX8237@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=gururaja.hebbar@ti.com \
--cc=lrg@ti.com \
--cc=mporter@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).