alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: alsa-devel@alsa-project.org
Cc: Clemens Ladisch <clemens@ladisch.de>
Subject: calling snd_ctl_notify from mixer ctl_put
Date: Thu, 11 Oct 2012 21:29:02 +0200	[thread overview]
Message-ID: <201210112129.03097.linux@rainbow-software.org> (raw)

Hello,
I want to enable/disable some mixer controls based on state of another control 
(switching between limiter and AGC mode). So I (re)set the 
SNDRV_CTL_ELEM_ACCESS_INACTIVE flag in kctl->vd[0].access
and then call snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_INFO, &kctl->id);
Everyting from ctl_put() mixer callback.

When changing the control value in alsamixer, it crashes with:
alsamixer: simple.c:948: snd_mixer_selem_get_enum_item: Assertion 
`(elem)->type == SND_MIXER_ELEM_SIMPLE' failed.

When the snd_ctl_notify() call is commented-out, it does not crash.

There is snd_ctl_activate_id() function in sound/core/control.c (not used by 
any driver, btw.) which does the same, protected by card->controls_rwsem. 
However, it locks up on that semaphore when called from the mixer callback.

Oxygen/Xonar WM8776 driver is doing the same thing - I wonder if I'm doing 
something wrong or if that driver crashes alsamixer too?

Is there any way to do this properly?

-- 
Ondrej Zary

             reply	other threads:[~2012-10-11 19:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11 19:29 Ondrej Zary [this message]
2012-10-12  6:03 ` calling snd_ctl_notify from mixer ctl_put Clemens Ladisch
2012-10-13 21:23   ` Ondrej Zary
2012-10-21  1:06     ` Raymond Yau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210112129.03097.linux@rainbow-software.org \
    --to=linux@rainbow-software.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).