[PATCH 1/1] ALSA: hda - add quirk for Thinkpad T430

[PATCH 1/1] ALSA: hda - add quirk for Thinkpad T430

[joseph.salisbury]

From: Joseph Salisbury <joseph.salisbury@canonical.com>


Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
---
 sound/pci/hda/patch_realtek.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 739f968..18fce01 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6172,6 +6172,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x21e9, "Thinkpad Edge 15", ALC269_FIXUP_SKU_IGNORE),
 	SND_PCI_QUIRK(0x17aa, 0x21f6, "Thinkpad T530", ALC269_FIXUP_LENOVO_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x21fa, "Thinkpad X230", ALC269_FIXUP_LENOVO_DOCK),
+	SND_PCI_QUIRK(0x17aa, 0x21f3, "Thinkpad T430", ALC269_FIXUP_LENOVO_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x21fb, "Thinkpad T430s", ALC269_FIXUP_LENOVO_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x2203, "Thinkpad X230 Tablet", ALC269_FIXUP_LENOVO_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
-- 
1.7.9.5

Re: [PATCH 0/1] ALSA: hda - add quirk for Thinkpad T430

[Jonathan Nieder]

Hi Joseph,

joseph.salisbury@canonical.com wrote:

> [Subject: [PATCH 0/1] ALSA: hda - add quirk for Thinkpad T430]]
[...]
> This patch is to enable audio on T430 Thinkpads.  There is no audo
> from the headphone jack without this patch.  This patch adds a quirk
> for the T430 model.  

Please don't do this cover-letter thing.  A cover letter can be a
good way to *summarize* a long patch series so readers are less
daunted, but any information that was needed to know in order to
evaluate a patch, briefly stated, should be in the commit message that
actually gets committed.

Thanks and hope that helps,
Jonathan

[PATCH v2 1/1] ALSA: hda - add quirk for Thinkpad T430

[joseph.salisbury]

From: Joseph Salisbury <joseph.salisbury@canonical.com>

This patch adds a quirk to enable headphone jack audio on T430 Thinkpads.

Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: <stable@vger.kernel.org>

---
 sound/pci/hda/patch_realtek.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 739f968..18fce01 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6172,6 +6172,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x21e9, "Thinkpad Edge 15", ALC269_FIXUP_SKU_IGNORE),
 	SND_PCI_QUIRK(0x17aa, 0x21f6, "Thinkpad T530", ALC269_FIXUP_LENOVO_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x21fa, "Thinkpad X230", ALC269_FIXUP_LENOVO_DOCK),
+	SND_PCI_QUIRK(0x17aa, 0x21f3, "Thinkpad T430", ALC269_FIXUP_LENOVO_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x21fb, "Thinkpad T430s", ALC269_FIXUP_LENOVO_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x2203, "Thinkpad X230 Tablet", ALC269_FIXUP_LENOVO_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
-- 
1.7.9.5

Re: [PATCH 1/1] ALSA: hda - add quirk for Thinkpad T430

[Greg KH]

On Fri, Oct 19, 2012 at 10:32:30AM -0400, joseph.salisbury@canonical.com wrote:
> From: Joseph Salisbury <joseph.salisbury@canonical.com>
> 
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c |    1 +
>  1 file changed, 1 insertion(+)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

Re: [PATCH v2 1/1] ALSA: hda - add quirk for Thinkpad T430

[Jonathan Nieder]

joseph.salisbury@canonical.com wrote:

> This patch adds a quirk to enable headphone jack audio on T430 Thinkpads.
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Cc: <stable@vger.kernel.org>

Thanks --- this is a little better.

One more nit: it looks like this was reported, tested, and based on a
patch by Stefan Freyr.  Takashi, could you amend the message to
reflect that, or should the patch be resent?

Something like

-- >8 --
From: Stefán Freyr <stefan.freyr@gmail.com>
Subject: ALSA: hda - add dock support for Thinkpad T430

I have a Lenovo ThinkPad T430 and an UltraBase Series 3 docking
station.

Without this patch, if I plug my headphones into the jack on the
computer, everything works fine. The computer speakers mute and the
audio is played in the headphones. However, if I plug into the docking
station headphone jack the computer speakers are muted but there is no
audio in the headphones.

Addresses https://bugs.launchpad.net/bugs/1060372

Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: stable@vger.kernel.org

Re: [PATCH v2 1/1] ALSA: hda - add quirk for Thinkpad T430

[Takashi Iwai]

At Fri, 19 Oct 2012 12:54:21 -0700,
Jonathan Nieder wrote:
> 
> joseph.salisbury@canonical.com wrote:
> 
> > This patch adds a quirk to enable headphone jack audio on T430 Thinkpads.
> >
> > Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> > Cc: <stable@vger.kernel.org>
> 
> Thanks --- this is a little better.
> 
> One more nit: it looks like this was reported, tested, and based on a
> patch by Stefan Freyr.  Takashi, could you amend the message to
> reflect that, or should the patch be resent?

Yes, applied now with the improved commit log.


thanks,

Takashi

> 
> Something like
> 
> -- >8 --
> From: Stefán Freyr <stefan.freyr@gmail.com>
> Subject: ALSA: hda - add dock support for Thinkpad T430
> 
> I have a Lenovo ThinkPad T430 and an UltraBase Series 3 docking
> station.
> 
> Without this patch, if I plug my headphones into the jack on the
> computer, everything works fine. The computer speakers mute and the
> audio is played in the headphones. However, if I plug into the docking
> station headphone jack the computer speakers are muted but there is no
> audio in the headphones.
> 
> Addresses https://bugs.launchpad.net/bugs/1060372
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Cc: stable@vger.kernel.org
>