* Re: [PATCH] ASoC: supply and micbiases shoud bring "up to" STANDBY
[not found] <5FBF8E85CA34454794F0F7ECBA79798F37A052B72B@HQMAIL04.nvidia.com>
@ 2012-10-25 16:49 ` Mark Brown
0 siblings, 0 replies; only message in thread
From: Mark Brown @ 2012-10-25 16:49 UTC (permalink / raw)
To: Shaoming Feng; +Cc: Daniel Solomon, Stephen Warren, alsa-devel@alsa-project.org
[-- Attachment #1.1: Type: text/plain, Size: 1047 bytes --]
On Wed, Oct 24, 2012 at 02:19:35PM -0700, Shaoming Feng wrote:
> /* Supplies and micbiases only bring the
> * context up to STANDBY as unless something
> * else is active and passing audio they
> * generally don't require full power. Signal
> * generators are virtual pins and have no
> * power impact themselves.
> */
> According to the comment, the target bias level shouldn't be higher than STANDBY.
> case snd_soc_dapm_clock_supply:
> case snd_soc_dapm_micbias:
> - if (d->target_bias_level < SND_SOC_BIAS_STANDBY)
> + if (d->target_bias_level > SND_SOC_BIAS_STANDBY)
> d->target_bias_level = SND_SOC_BIAS_STANDBY;
This will do the wrong thing - it'll mean that if we've already found
that we need a bias level over _STANDBY we'll pull back to only
selecting _STANDBY. The intention here is that we should raise to
_STANDBY but this shouldn't distrupt operation of other widgets.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] only message in thread