alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: omap-dmic: Correct functional clock name
@ 2012-10-26 10:33 Peter Ujfalusi
  2012-10-27 22:01 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2012-10-26 10:33 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: alsa-devel

We should really use "fck" when asking for the functional clock and not
"dmic_fck".
This way we can ensure that multiple dmic modules can exist in the system.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi Mark, Liam,

Would it be possible to send this patch for 3.7 as a fix?
The DMIC driver works withoput this patch but we ask for the functional clock
using the wrong name.

Thanks,
Peter

 sound/soc/omap/omap-dmic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
index 68f2cd1..5a6aeaf 100644
--- a/sound/soc/omap/omap-dmic.c
+++ b/sound/soc/omap/omap-dmic.c
@@ -464,9 +464,9 @@ static __devinit int asoc_dmic_probe(struct platform_device *pdev)
 
 	mutex_init(&dmic->mutex);
 
-	dmic->fclk = clk_get(dmic->dev, "dmic_fck");
+	dmic->fclk = clk_get(dmic->dev, "fck");
 	if (IS_ERR(dmic->fclk)) {
-		dev_err(dmic->dev, "cant get dmic_fck\n");
+		dev_err(dmic->dev, "cant get fck\n");
 		return -ENODEV;
 	}
 
-- 
1.7.12.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: omap-dmic: Correct functional clock name
  2012-10-26 10:33 [PATCH] ASoC: omap-dmic: Correct functional clock name Peter Ujfalusi
@ 2012-10-27 22:01 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-10-27 22:01 UTC (permalink / raw)
  To: Peter Ujfalusi; +Cc: alsa-devel, Liam Girdwood


[-- Attachment #1.1: Type: text/plain, Size: 391 bytes --]

On Fri, Oct 26, 2012 at 12:33:08PM +0200, Peter Ujfalusi wrote:

> Would it be possible to send this patch for 3.7 as a fix?
> The DMIC driver works withoput this patch but we ask for the functional clock
> using the wrong name.

So, this has no practical effect but we should fix it for the next
release...?   I've applied it as a fix but better motivation would help
for things like this.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-27 22:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-26 10:33 [PATCH] ASoC: omap-dmic: Correct functional clock name Peter Ujfalusi
2012-10-27 22:01 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).