From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Paolo Doz <paolo.doz@gmail.com>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH 1/4] ASoC: ak5702: add support for ak5702 -- 4ch ADC
Date: Mon, 29 Oct 2012 16:04:51 +0000 [thread overview]
Message-ID: <20121029160450.GB4511@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAFsPKCXpZ43SBXyPTJnXR9mUgXyLK0T=JBiQrkBWGzSJOuLptA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 541 bytes --]
On Mon, Oct 29, 2012 at 09:43:57AM +0100, Paolo Doz wrote:
> This codec driver adds support for Asahi Kasei AK5702.
>
> Signed-off-by: Paolo Doz <paolo.doz@gmail.com>
Lars-Peter already went through most of this so I'll not follow up in
detail. One overall comment which Lars-Peter didn't make but which it's
worth bearing in mind was that your driver looks like it was written
several years ago, it'd probably help a lot if you were to look at more
modern drivers and make sure what you're doing resembles them
stylistically.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-10-29 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 8:43 [PATCH 1/4] ASoC: ak5702: add support for ak5702 -- 4ch ADC Paolo Doz
2012-10-29 12:41 ` Lars-Peter Clausen
2012-10-29 16:04 ` Mark Brown [this message]
2012-10-29 17:49 ` Paolo Doz
2012-10-29 18:17 ` Mark Brown
2012-11-26 16:14 ` Paolo Doz
2012-11-26 16:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029160450.GB4511@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=paolo.doz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox