From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, patches@linaro.org,
lrg@ti.com
Subject: Re: [PATCH 6/6] ASoC: dapm: Fix potential NULL pointer dereference
Date: Sun, 2 Dec 2012 13:14:34 +0900 [thread overview]
Message-ID: <20121202041433.GT17981@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1353488819-13902-6-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 357 bytes --]
On Wed, Nov 21, 2012 at 02:36:59PM +0530, Sachin Kamat wrote:
> if (!w) {
> dev_err(dapm->dev, "Failed to create %s widget\n",
> dai->driver->playback.stream_name);
> + } else {
> + w->priv = dai;
> }
This isn't a particularly sensible fix, we should be erroring out or
something rather than limping along with the rest of the function.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-12-02 4:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 9:06 [PATCH 1/6] ALSA: PCM: Remove redundant null check before kfree Sachin Kamat
2012-11-21 9:06 ` [PATCH 2/6] ALSA: pcm: Fix return code in pcm_native.c Sachin Kamat
2012-11-21 9:45 ` Takashi Iwai
2012-11-21 9:06 ` [PATCH 3/6] ASoC: Samsung-dma: Fix potential NULL pointer dereference Sachin Kamat
2012-12-02 4:12 ` Mark Brown
2012-11-21 9:06 ` [PATCH 4/6] ALSA: usb: Fix potential NULL pointer dereference in comm.c Sachin Kamat
2012-11-21 9:45 ` Takashi Iwai
2012-11-21 9:06 ` [PATCH 5/6] ALSA: usb-audio: Return -ENOMEM on memory alloc failure in format.c Sachin Kamat
2012-11-21 9:45 ` Takashi Iwai
2012-11-21 9:56 ` Sachin Kamat
2012-11-21 9:06 ` [PATCH 6/6] ASoC: dapm: Fix potential NULL pointer dereference Sachin Kamat
2012-11-28 4:43 ` Sachin Kamat
2012-11-28 17:28 ` Mark Brown
2012-12-02 4:14 ` Mark Brown [this message]
2012-11-21 9:44 ` [PATCH 1/6] ALSA: PCM: Remove redundant null check before kfree Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121202041433.GT17981@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox