From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: wm8993: Refactor set_pll code to avoid GCC warnings
Date: Wed, 12 Dec 2012 12:21:31 +0900 [thread overview]
Message-ID: <20121212032129.GB30719@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1355282392-30693-1-git-send-email-festevam@gmail.com>
On Wed, Dec 12, 2012 at 01:19:52AM -0200, Fabio Estevam wrote:
> - if (freq_in && freq_out) {
> + if (!freq_in || !freq_out) {
> + /* disable the PLL before re-programming it */
> + snd_soc_update_bits(codec, WM8983_POWER_MANAGEMENT_1,
> + WM8983_PLLEN_MASK, 0);
> + return 0;
This comment clearly doesn't match the code.
prev parent reply other threads:[~2012-12-12 3:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 3:19 [PATCH] ASoC: wm8993: Refactor set_pll code to avoid GCC warnings Fabio Estevam
2012-12-12 3:21 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212032129.GB30719@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).