From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
Liam Girdwood <lrg-l0cyMroinI0@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/7] ASoC: allow wolfson wm9712 codec to be instantiated using device tree
Date: Thu, 20 Dec 2012 09:32:14 +0000 [thread overview]
Message-ID: <20121220093214.GZ4985@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1355959056-6009-2-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Thu, Dec 20, 2012 at 12:17:31AM +0100, Lucas Stach wrote:
> static struct platform_driver wm9712_codec_driver = {
> .driver = {
> .name = "wm9712-codec",
> .owner = THIS_MODULE,
> + .of_match_table = wm9712_of_match,
> },
No, this is really not a sane way of handling AC'97 at all. They're not
platform devices, there is no sane reason why they should appear in the
device tree as such. Really we ought to be just hotplugging them, AC'97
is perfectly enumerable.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-20 9:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 23:17 [PATCH 1/7] ARM: tegra: add ac97 clock Lucas Stach
[not found] ` <1355959056-6009-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2012-12-19 23:17 ` [PATCH 2/7] ASoC: allow wolfson wm9712 codec to be instantiated using device tree Lucas Stach
[not found] ` <1355959056-6009-2-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2012-12-20 9:32 ` Mark Brown [this message]
2012-12-19 23:17 ` [PATCH 3/7] ASoC: tegra: setup DAP3<->DAC3 connection by default Lucas Stach
[not found] ` <1355959056-6009-3-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2012-12-20 19:20 ` Stephen Warren
2012-12-24 16:01 ` Mark Brown
2012-12-19 23:17 ` [PATCH 4/7] ASoC: tegra: add function to set ac97 rate Lucas Stach
[not found] ` <1355959056-6009-4-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2012-12-20 19:22 ` Stephen Warren
2012-12-24 16:00 ` Mark Brown
2012-12-19 23:17 ` [PATCH 5/7] ASoC: tegra: add ac97 host driver Lucas Stach
[not found] ` <1355959056-6009-5-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2012-12-20 19:44 ` Stephen Warren
[not found] ` <50D36A98.7090204-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-20 20:10 ` Lucas Stach
2012-12-20 20:19 ` Stephen Warren
[not found] ` <50D372DF.2080600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-20 20:32 ` Lucas Stach
2012-12-20 20:23 ` Mark Brown
2012-12-19 23:17 ` [PATCH 6/7] ASoC: tegra: add ac97 host controller to device tree Lucas Stach
[not found] ` <1355959056-6009-6-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2012-12-20 19:47 ` Stephen Warren
2012-12-19 23:17 ` [PATCH 7/7] ASoC: tegra: add machine driver using wm9712 codec Lucas Stach
[not found] ` <1355959056-6009-7-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2012-12-20 19:55 ` Stephen Warren
[not found] ` <50D36D3B.7080309-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-20 20:16 ` Mark Brown
2012-12-20 19:24 ` [PATCH 1/7] ARM: tegra: add ac97 clock Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220093214.GZ4985@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-l0cyMroinI0@public.gmane.org \
--cc=patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).