From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lrg@ti.com" <lrg@ti.com>
Subject: Re: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases
Date: Thu, 20 Dec 2012 13:51:05 +0000 [thread overview]
Message-ID: <20121220135104.GB4985@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A1F3CA7@SHSMSX101.ccr.corp.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 633 bytes --]
On Thu, Dec 20, 2012 at 06:37:26AM +0000, Liu, Chuansheng wrote:
> Meanwhile, is it useful to add one warning there for that case?
> After all, in probing, set the bias to _STANDBY even idle_bias_off == 1, and calling get_runtime_sync(), it
> will let the code more obscure. So giving a warning there to indicate the driver:
> it is not suggested that in probing, set the bias to _STANDBY even idle_bias_off == 1.
Probably, send a patch please. Like I say it is possible to start off
in _STANDBY providing the driver grabs the runtime PM reference too but
I can't think of any reason for doing that so the warning seems sensible.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-12-20 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 10:36 [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases Chuansheng Liu
2012-12-19 9:11 ` Mark Brown
2012-12-20 6:37 ` Liu, Chuansheng
2012-12-20 13:51 ` Mark Brown [this message]
2012-12-21 1:34 ` Liu, Chuansheng
2012-12-21 10:17 ` [PATCH] ASoC: core: giving WARN when device starting from non-off bias with idle_bias_off Chuansheng Liu
2012-12-24 15:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220135104.GB4985@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).