alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: "Omair M. Abdullah" <omair.m.abdullah@intel.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	M R Swami Reddy <MR.Swami.Reddy@ti.com>,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH RFT] ASoC: lm49453: Fix mask for setting mode bit in lm49453_set_dai_fmt()
Date: Mon, 24 Dec 2012 11:08:22 +0530	[thread overview]
Message-ID: <20121224053822.GA26412@oma-dev> (raw)
In-Reply-To: <1356052760.9177.1.camel@phoenix>

On Fri, Dec 21, 2012 at 09:19:20AM +0800, Axel Lin wrote:
> The mode variable is either 0 or 1.
> To update mode setting, the mask should be BIT(0) rather than BIT(1).
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi M R Swami,
> I don't have the datasheet. Can you check if this patch is correct?
Yes, according to the datasheet the STEREO mode is BIT(0).

> Thanks,
> Axel
>  sound/soc/codecs/lm49453.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
> index d75257d..c0d203b 100644
> --- a/sound/soc/codecs/lm49453.c
> +++ b/sound/soc/codecs/lm49453.c
> @@ -1218,7 +1218,7 @@ static int lm49453_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
>  	}
>  
>  	snd_soc_update_bits(codec, LM49453_P0_AUDIO_PORT1_BASIC_REG,
> -			    LM49453_AUDIO_PORT1_BASIC_FMT_MASK|BIT(1)|BIT(5),
> +			    LM49453_AUDIO_PORT1_BASIC_FMT_MASK|BIT(0)|BIT(5),
>  			    (aif_val | mode | clk_phase));
>  
>  	snd_soc_write(codec, LM49453_P0_AUDIO_PORT1_RX_MSB_REG, clk_shift);
> -- 
> 1.7.9.5
> 
> 
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2012-12-24  5:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-21  1:19 [PATCH RFT] ASoC: lm49453: Fix mask for setting mode bit in lm49453_set_dai_fmt() Axel Lin
2012-12-24  5:38 ` Omair M. Abdullah [this message]
2012-12-24 15:32 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121224053822.GA26412@oma-dev \
    --to=omair.m.abdullah@intel.com \
    --cc=MR.Swami.Reddy@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@ingics.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).