[PATCH] ASoC: atmel-ssc: make it buildable on other architectures

[PATCH] ASoC: atmel-ssc: make it buildable on other architectures

[Joachim Eastwood]

Not very useful on non AT91/AVR32 platforms but it provides
more build coverage and prepares for ARM multiplatform.

Also fixes a truncated warning that would come when
building on a 64-bit arch.

Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---

Hi Mark,

Sending it to you since seem like you're the last one who
commited changes to the driver and the driver is mostly
used on ASoC.

Tested on RM9200 and build tested on x86_64.

regards
Joachim Eastwood

 drivers/misc/Kconfig     | 2 +-
 drivers/misc/atmel-ssc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index b151b7c..8f59d88 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -192,7 +192,7 @@ config ICS932S401
 
 config ATMEL_SSC
 	tristate "Device driver for Atmel SSC peripheral"
-	depends on AVR32 || ARCH_AT91
+	depends on HAS_IOMEM
 	---help---
 	  This option enables device driver support for Atmel Synchronized
 	  Serial Communication peripheral (SSC).
diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index 158da5a..0cee274 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -167,7 +167,7 @@ static int ssc_probe(struct platform_device *pdev)
 
 	/* disable all interrupts */
 	clk_enable(ssc->clk);
-	ssc_writel(ssc->regs, IDR, ~0UL);
+	ssc_writel(ssc->regs, IDR, -1);
 	ssc_readl(ssc->regs, SR);
 	clk_disable(ssc->clk);
 
-- 
1.8.0

Re: [PATCH] ASoC: atmel-ssc: make it buildable on other architectures

[Bo Shen]

Hi Joachim Eastwood,

On 12/8/2012 20:46, Joachim Eastwood wrote:
> Not very useful on non AT91/AVR32 platforms but it provides
> more build coverage and prepares for ARM multiplatform.
>
> Also fixes a truncated warning that would come when
> building on a 64-bit arch.
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
>
> Hi Mark,
>
> Sending it to you since seem like you're the last one who
> commited changes to the driver and the driver is mostly
> used on ASoC.
>
> Tested on RM9200 and build tested on x86_64.
>
> regards
> Joachim Eastwood
>
>   drivers/misc/Kconfig     | 2 +-
>   drivers/misc/atmel-ssc.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index b151b7c..8f59d88 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -192,7 +192,7 @@ config ICS932S401
>
>   config ATMEL_SSC
>   	tristate "Device driver for Atmel SSC peripheral"
> -	depends on AVR32 || ARCH_AT91
> +	depends on HAS_IOMEM
>   	---help---
>   	  This option enables device driver support for Atmel Synchronized
>   	  Serial Communication peripheral (SSC).
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 158da5a..0cee274 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -167,7 +167,7 @@ static int ssc_probe(struct platform_device *pdev)
>
>   	/* disable all interrupts */
>   	clk_enable(ssc->clk);
> -	ssc_writel(ssc->regs, IDR, ~0UL);
> +	ssc_writel(ssc->regs, IDR, -1);

I don't meet building warning on x86_64 machine. So, would you please 
explain more why need change this?

Best Regards,
Bo Shen

>   	ssc_readl(ssc->regs, SR);
>   	clk_disable(ssc->clk);
>
>

Re: [PATCH] ASoC: atmel-ssc: make it buildable on other architectures

[Nicolas Ferre]

On 12/08/2012 01:46 PM, Joachim Eastwood :
> Not very useful on non AT91/AVR32 platforms but it provides
> more build coverage and prepares for ARM multiplatform.
> 
> Also fixes a truncated warning that would come when
> building on a 64-bit arch.
> 
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>

It if needs it to go forward:

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
> 
> Hi Mark,
> 
> Sending it to you since seem like you're the last one who
> commited changes to the driver and the driver is mostly
> used on ASoC.
> 
> Tested on RM9200 and build tested on x86_64.
> 
> regards
> Joachim Eastwood
> 
>  drivers/misc/Kconfig     | 2 +-
>  drivers/misc/atmel-ssc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index b151b7c..8f59d88 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -192,7 +192,7 @@ config ICS932S401
>  
>  config ATMEL_SSC
>  	tristate "Device driver for Atmel SSC peripheral"
> -	depends on AVR32 || ARCH_AT91
> +	depends on HAS_IOMEM
>  	---help---
>  	  This option enables device driver support for Atmel Synchronized
>  	  Serial Communication peripheral (SSC).
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 158da5a..0cee274 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -167,7 +167,7 @@ static int ssc_probe(struct platform_device *pdev)
>  
>  	/* disable all interrupts */
>  	clk_enable(ssc->clk);
> -	ssc_writel(ssc->regs, IDR, ~0UL);
> +	ssc_writel(ssc->regs, IDR, -1);
>  	ssc_readl(ssc->regs, SR);
>  	clk_disable(ssc->clk);
>  
> 


-- 
Nicolas Ferre

Re: [PATCH] ASoC: atmel-ssc: make it buildable on other architectures

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

On Sat, Dec 08, 2012 at 01:46:41PM +0100, Joachim Eastwood wrote:
> Not very useful on non AT91/AVR32 platforms but it provides
> more build coverage and prepares for ARM multiplatform.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]