From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: vinod.koul@intel.com, Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>, Liam Girdwood <lrg@ti.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: fsi: add device tree support
Date: Thu, 3 Jan 2013 12:48:56 +0000 [thread overview]
Message-ID: <20130103124855.GH4627@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <87pq1uyiij.wl%kuninori.morimoto.gx@renesas.com>
[-- Attachment #1.1: Type: text/plain, Size: 881 bytes --]
On Thu, Dec 27, 2012 at 07:15:19PM -0800, Kuninori Morimoto wrote:
> +- fsia,flags : FSI-A flags [spdif/cpg/stream]
> +- fsia,tx_id : FSI-A DMAEngine ID if needed
> +- fsib,flags : FSI-B flags [spdif/cpg/stream]
> +- fsib,tx_id : FSI-B DMAEngine ID if needed
The flags should be documented - what do these flags mean? The
DMAEngine stuff is a bit fun but I don't think there's yet been any
resolution of what to do with DMAEngine in DT yet...
> +FSI needs simple-card driver. see also simple-card.txt
This isn't true, the driver can be used with any machine driver. It's
true that many machines using the FSI driver can be supported with the
simple-card driver but others are also fine.
> + { "cpg", SH_FSI_CLK_CPG },
Is this definitely something that would be fixed by hardware design?
> + { "stream", SH_FSI_ENABLE_STREAM_MODE },
Why wouldn't stream mode be desired?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-01-03 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 3:14 [PATCH 0/2] ASoC: fsi: add DT support Kuninori Morimoto
2012-12-28 3:15 ` [PATCH 1/2] ASoC: fsi: don't use platform info pointer on probe() Kuninori Morimoto
2013-01-03 12:51 ` Mark Brown
2012-12-28 3:15 ` [PATCH 1/2] ASoC: fsi: add device tree support Kuninori Morimoto
2013-01-03 12:48 ` Mark Brown [this message]
2013-01-08 0:02 ` Kuninori Morimoto
2013-01-10 8:34 ` [PATCH v2] " Kuninori Morimoto
2013-01-13 23:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103124855.GH4627@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lrg@ti.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).