From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: mxs-saif: Use a signed integer for error value
Date: Tue, 8 Jan 2013 12:33:23 +0000 [thread overview]
Message-ID: <20130108123322.GV4544@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1357648033-8101-1-git-send-email-fabio.estevam@freescale.com>
[-- Attachment #1.1: Type: text/plain, Size: 372 bytes --]
On Tue, Jan 08, 2013 at 10:27:13AM -0200, Fabio Estevam wrote:
> - saif->id = of_alias_get_id(np, "saif");
> - if (saif->id < 0)
> - return saif->id;
> + ret = of_alias_get_id(np, "saif");
> + if (ret < 0)
> + return ret;
Why not remove said->id completely if we don't need to store a value
there? Alternatively, this needs to store the id if the return value is
OK.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-01-08 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 12:27 [PATCH] ASoC: mxs-saif: Use a signed integer for error value Fabio Estevam
2013-01-08 12:33 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108123322.GV4544@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).