From: Yoichi Yuasa <yuasa@linux-mips.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
yuasa@linux-mips.org
Subject: Re: [PATCH 03/19] ALSA: ymu831: add B-DSP driver
Date: Thu, 17 Jan 2013 14:58:45 +0900 [thread overview]
Message-ID: <20130117145845.317d17da2d88013b71780062@linux-mips.org> (raw)
In-Reply-To: <s5hfw21pctq.wl%tiwai@suse.de>
On Wed, 16 Jan 2013 12:49:37 +0100
Takashi Iwai <tiwai@suse.de> wrote:
> At Wed, 16 Jan 2013 17:28:32 +0900,
> Yoichi Yuasa wrote:
> >
> > +static void bdsp_check_sin_control_sel(struct aec_bdsp_info *bdsp, u8 *data)
> > +{
> > + u32 addr;
> > + u32 size;
> > +
> > + addr = htonl(*(u32 *) data);
> > + size = htonl(*(u32 *) (data + 5));
>
> It's an unaligned access.
The size is unaligned.
I'll add a comment.
> And normally we use cpu_to_xxx() or
> xxx_to_cpu() macros for endian conversions.
I'll update them.
Thank you for your comment.
Yoichi
next prev parent reply other threads:[~2013-01-17 5:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 8:25 [PATCH 01/19] ALSA: add Yamaha YMU831 codec support Yoichi Yuasa
2013-01-16 8:27 ` [PATCH 02/19] ALSA: ymu831: add device register definitions Yoichi Yuasa
2013-01-16 11:45 ` Takashi Iwai
2013-01-17 5:59 ` Yoichi Yuasa
2013-01-17 6:45 ` Takashi Iwai
2013-01-17 10:33 ` Yoichi Yuasa
2013-01-16 13:18 ` Mark Brown
2013-01-17 6:00 ` Yoichi Yuasa
2013-01-17 6:02 ` Mark Brown
2013-01-17 6:24 ` Yoichi Yuasa
2013-01-16 8:28 ` [PATCH 03/19] ALSA: ymu831: add B-DSP driver Yoichi Yuasa
2013-01-16 11:49 ` Takashi Iwai
2013-01-17 5:58 ` Yoichi Yuasa [this message]
2013-01-16 13:22 ` Mark Brown
2013-01-17 5:59 ` Yoichi Yuasa
2013-01-17 6:07 ` Mark Brown
2013-01-16 8:29 ` [PATCH 04/19] ALSA: ymu831: add C-DSP operating system data Yoichi Yuasa
2013-01-16 13:23 ` Mark Brown
2013-01-16 8:31 ` [PATCH 05/19] ALSA: ymu831: add C-DSP driver Yoichi Yuasa
2013-01-16 13:32 ` Mark Brown
2013-01-16 8:32 ` [PATCH 06/19] ALSA: ymu831: add device interface driver Yoichi Yuasa
2013-01-16 13:36 ` Mark Brown
2013-01-16 8:33 ` [PATCH 07/19] ALSA: ymu831: add base driver Yoichi Yuasa
2013-01-16 13:43 ` Mark Brown
2013-01-16 8:34 ` [PATCH 08/19] ALSA: ymu831: add E-DSP driver Yoichi Yuasa
2013-01-16 8:35 ` [PATCH 09/19] ALSA: ymu831: add F-DSP driver Yoichi Yuasa
2013-01-16 8:36 ` [PATCH 10/19] ALSA: ymu831: add device control packet packing driver Yoichi Yuasa
2013-01-16 8:37 ` [PATCH 11/19] ALSA: ymu831: add data parser Yoichi Yuasa
2013-01-16 8:38 ` [PATCH 12/19] ALSA: ymu831: add resource control driver Yoichi Yuasa
2013-01-16 8:39 ` [PATCH 13/19] ALSA: yum831: add configurations header Yoichi Yuasa
2013-01-16 8:40 ` [PATCH 14/19] ALSA: ymu831: add codec control definitions Yoichi Yuasa
2013-01-16 8:41 ` [PATCH 15/19] ALSA: ymu831: add path configurations header Yoichi Yuasa
2013-01-16 8:42 ` [PATCH 16/19] ALSA: ymu831: add volume map header Yoichi Yuasa
2013-01-16 8:43 ` [PATCH 17/19] ALSA: ymu831: add codec driver Yoichi Yuasa
2013-01-16 14:16 ` Mark Brown
2013-01-16 8:44 ` [PATCH 18/19] ALSA: ymu831: add hwdep ioctl Yoichi Yuasa
2013-01-16 11:53 ` Takashi Iwai
2013-01-16 13:53 ` Mark Brown
2013-01-16 8:46 ` [PATCH 19/19] ALSA: SoC Audio support for OMAP4 boards with Yamaha YMU831 codec Yoichi Yuasa
2013-01-16 13:48 ` Mark Brown
2013-01-16 11:38 ` [PATCH 01/19] ALSA: add Yamaha YMU831 codec support Takashi Iwai
2013-01-16 11:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117145845.317d17da2d88013b71780062@linux-mips.org \
--to=yuasa@linux-mips.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).