From: Yoichi Yuasa <yuasa@linux-mips.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patch@alsa-project.org,
yuasa@linux-mips.org
Subject: Re: [PATCH 03/19] ALSA: ymu831: add B-DSP driver
Date: Thu, 17 Jan 2013 14:59:12 +0900 [thread overview]
Message-ID: <20130117145912.10c5650712b73552ad9c4068@linux-mips.org> (raw)
In-Reply-To: <20130116132245.GB16235@sirena.org.uk>
On Wed, 16 Jan 2013 13:22:45 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Jan 16, 2013 at 05:28:32PM +0900, Yoichi Yuasa wrote:
> >
> > Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
> > ---
> > sound/soc/codecs/ymu831/Makefile | 1 +
> > sound/soc/codecs/ymu831/mcbdspdrv.c | 1193 +++++++++++++++++++++++++++++++++++
>
> Why the subdirectory?
ymu831 driver has 27 files.
It is the reason that I made the subdirectory.
Is it better to put them on sound/soc/codes ?
> Also this file is over 1000 lines of code with
> basically no comments or relationship with standard kernel code. This
> is a substandial barrier to review; at the very least it would be
> helpful to split this up into multiple patches, one per algorithm for
> example.
OK, I'll split it.
>
> > +/*
> > + * changelog:
> > + * - change in the Linux coding style
> > + * - remove unnecessary comments
> > + * - remove unused codes
> > + */
>
> No changelogs in kernel code.
OK, I'll remove them.
Thank you for your comments.
Yoichi
next prev parent reply other threads:[~2013-01-17 5:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 8:25 [PATCH 01/19] ALSA: add Yamaha YMU831 codec support Yoichi Yuasa
2013-01-16 8:27 ` [PATCH 02/19] ALSA: ymu831: add device register definitions Yoichi Yuasa
2013-01-16 11:45 ` Takashi Iwai
2013-01-17 5:59 ` Yoichi Yuasa
2013-01-17 6:45 ` Takashi Iwai
2013-01-17 10:33 ` Yoichi Yuasa
2013-01-16 13:18 ` Mark Brown
2013-01-17 6:00 ` Yoichi Yuasa
2013-01-17 6:02 ` Mark Brown
2013-01-17 6:24 ` Yoichi Yuasa
2013-01-16 8:28 ` [PATCH 03/19] ALSA: ymu831: add B-DSP driver Yoichi Yuasa
2013-01-16 11:49 ` Takashi Iwai
2013-01-17 5:58 ` Yoichi Yuasa
2013-01-16 13:22 ` Mark Brown
2013-01-17 5:59 ` Yoichi Yuasa [this message]
2013-01-17 6:07 ` Mark Brown
2013-01-16 8:29 ` [PATCH 04/19] ALSA: ymu831: add C-DSP operating system data Yoichi Yuasa
2013-01-16 13:23 ` Mark Brown
2013-01-16 8:31 ` [PATCH 05/19] ALSA: ymu831: add C-DSP driver Yoichi Yuasa
2013-01-16 13:32 ` Mark Brown
2013-01-16 8:32 ` [PATCH 06/19] ALSA: ymu831: add device interface driver Yoichi Yuasa
2013-01-16 13:36 ` Mark Brown
2013-01-16 8:33 ` [PATCH 07/19] ALSA: ymu831: add base driver Yoichi Yuasa
2013-01-16 13:43 ` Mark Brown
2013-01-16 8:34 ` [PATCH 08/19] ALSA: ymu831: add E-DSP driver Yoichi Yuasa
2013-01-16 8:35 ` [PATCH 09/19] ALSA: ymu831: add F-DSP driver Yoichi Yuasa
2013-01-16 8:36 ` [PATCH 10/19] ALSA: ymu831: add device control packet packing driver Yoichi Yuasa
2013-01-16 8:37 ` [PATCH 11/19] ALSA: ymu831: add data parser Yoichi Yuasa
2013-01-16 8:38 ` [PATCH 12/19] ALSA: ymu831: add resource control driver Yoichi Yuasa
2013-01-16 8:39 ` [PATCH 13/19] ALSA: yum831: add configurations header Yoichi Yuasa
2013-01-16 8:40 ` [PATCH 14/19] ALSA: ymu831: add codec control definitions Yoichi Yuasa
2013-01-16 8:41 ` [PATCH 15/19] ALSA: ymu831: add path configurations header Yoichi Yuasa
2013-01-16 8:42 ` [PATCH 16/19] ALSA: ymu831: add volume map header Yoichi Yuasa
2013-01-16 8:43 ` [PATCH 17/19] ALSA: ymu831: add codec driver Yoichi Yuasa
2013-01-16 14:16 ` Mark Brown
2013-01-16 8:44 ` [PATCH 18/19] ALSA: ymu831: add hwdep ioctl Yoichi Yuasa
2013-01-16 11:53 ` Takashi Iwai
2013-01-16 13:53 ` Mark Brown
2013-01-16 8:46 ` [PATCH 19/19] ALSA: SoC Audio support for OMAP4 boards with Yamaha YMU831 codec Yoichi Yuasa
2013-01-16 13:48 ` Mark Brown
2013-01-16 11:38 ` [PATCH 01/19] ALSA: add Yamaha YMU831 codec support Takashi Iwai
2013-01-16 11:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117145912.10c5650712b73552ad9c4068@linux-mips.org \
--to=yuasa@linux-mips.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patch@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).