From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: vinod.koul@linux.intel.com, tiwai@suse.de,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
liam.r.girdwood@intel.com
Subject: Re: [PATCH] ASoC: soc-compress: Cancel delayed power down if needed
Date: Sat, 26 Jan 2013 16:52:36 +0800 [thread overview]
Message-ID: <20130126085234.GB30594@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1359128299-17161-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 360 bytes --]
On Fri, Jan 25, 2013 at 03:38:19PM +0000, Charles Keepax wrote:
> + /* cancel any delayed stream shutdown that is pending */
> + if (codec_dai->pop_wait) {
> + codec_dai->pop_wait = 0;
> + cancel_delayed_work(&rtd->delayed_work);
> + }
This looks racy - the check for pop_wait can't be doing a huge amount
here, the work might already have been scheduled.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-01-26 9:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 15:38 [PATCH] ASoC: soc-compress: Cancel delayed power down if needed Charles Keepax
2013-01-25 16:56 ` [PATCH v2] " Charles Keepax
2013-01-26 8:52 ` Mark Brown [this message]
2013-03-08 16:52 ` [PATCH v3] " Charles Keepax
2013-03-11 9:25 ` [PATCH v4] " Charles Keepax
2013-03-20 10:25 ` Mark Brown
2013-03-22 8:50 ` [PATCH v5] " Charles Keepax
2013-03-26 17:51 ` Mark Brown
2013-03-27 11:41 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130126085234.GB30594@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=liam.r.girdwood@intel.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).