From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
patches@opensource.wolfsonmicro.com, liam.r.girdwood@intel.com,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
vinod.koul@linux.jf.intel.com
Subject: Re: [PATCH] ASoC: soc-compress: Add support for not memory mapped DSPs
Date: Mon, 28 Jan 2013 01:34:49 -0800 [thread overview]
Message-ID: <20130128093449.GO26562@intel.com> (raw)
In-Reply-To: <20130128064440.GB5683@opensource.wolfsonmicro.com>
On Mon, Jan 28, 2013 at 02:44:42PM +0800, Mark Brown wrote:
> > > We'd need to take a copy of it in case we have a system with a mix of
> > > both styles.
Yes that would be the right thing to do..
> > For the same device?
>
> No, not for the same device - just in the system. compr->ops has been
> set to point to soc_compr_ops which is a static shared by all drivers in
> the system (unless I've misread what you wrote above).
No you read it right. We need to change a little and yes take a copy of it.
That way you can modify the copy locally for your device rather that updating
the system while avoiding two defines :)
--
~Vinod
next prev parent reply other threads:[~2013-01-28 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 9:00 [PATCH] ASoC: soc-compress: Add support for not memory mapped DSPs Charles Keepax
2013-01-28 4:04 ` Vinod Koul
2013-01-28 4:56 ` Mark Brown
2013-01-28 6:09 ` Vinod Koul
2013-01-28 6:44 ` Mark Brown
2013-01-28 9:34 ` Vinod Koul [this message]
2013-01-28 10:49 ` Charles Keepax
2013-01-29 18:51 ` [PATCH v2] " Charles Keepax
2013-01-31 3:02 ` Vinod Koul
2013-02-05 10:41 ` [PATCH v3] " Charles Keepax
2013-02-05 11:54 ` Vinod Koul
2013-02-05 13:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130128093449.GO26562@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=liam.r.girdwood@intel.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@linux.jf.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).