From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
tiwai@suse.de, Mark Brown <broonie@opensource.wolfsonmicro.com>,
liam.r.girdwood@intel.com, vinod.koul@linux.jf.intel.com
Subject: Re: [PATCH] ASoC: soc-compress: Add support for not memory mapped DSPs
Date: Mon, 28 Jan 2013 10:49:10 +0000 [thread overview]
Message-ID: <20130128104910.GB14418@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130128093449.GO26562@intel.com>
On Mon, Jan 28, 2013 at 01:34:49AM -0800, Vinod Koul wrote:
> On Mon, Jan 28, 2013 at 02:44:42PM +0800, Mark Brown wrote:
> No you read it right. We need to change a little and yes take a copy of it.
> That way you can modify the copy locally for your device rather that updating
> the system while avoiding two defines :)
I can update the patch to create a new copy for each device
however, I am not sure I prefer this approach. It seems highly
likely that presence or not of copy will be the only difference
been devices that is ever present. So making dynamic copies per
device for what will only ever be two distinct items feels
excessive compared to the cost of carrying one extra static
struct.
Charles
next prev parent reply other threads:[~2013-01-28 10:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 9:00 [PATCH] ASoC: soc-compress: Add support for not memory mapped DSPs Charles Keepax
2013-01-28 4:04 ` Vinod Koul
2013-01-28 4:56 ` Mark Brown
2013-01-28 6:09 ` Vinod Koul
2013-01-28 6:44 ` Mark Brown
2013-01-28 9:34 ` Vinod Koul
2013-01-28 10:49 ` Charles Keepax [this message]
2013-01-29 18:51 ` [PATCH v2] " Charles Keepax
2013-01-31 3:02 ` Vinod Koul
2013-02-05 10:41 ` [PATCH v3] " Charles Keepax
2013-02-05 11:54 ` Vinod Koul
2013-02-05 13:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130128104910.GB14418@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=liam.r.girdwood@intel.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
--cc=vinod.koul@linux.jf.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).