[PATCH] ASoC: omap-pcm: No need to set constraint at open time

[PATCH] ASoC: omap-pcm: No need to set constraint at open time

[Peter Ujfalusi]

The same constraint is going to be set in the snd_dmaengine_pcm_open()
function, so there is no need to set it here as well.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 sound/soc/omap/omap-pcm.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 47bdbd4..c722c2e 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -174,23 +174,15 @@ static snd_pcm_uframes_t omap_pcm_pointer(struct snd_pcm_substream *substream)
 
 static int omap_pcm_open(struct snd_pcm_substream *substream)
 {
-	struct snd_pcm_runtime *runtime = substream->runtime;
 	struct snd_soc_pcm_runtime *rtd = substream->private_data;
 	struct omap_pcm_dma_data *dma_data;
-	int ret;
 
 	snd_soc_set_runtime_hwparams(substream, &omap_pcm_hardware);
 
-	/* Ensure that buffer size is a multiple of period size */
-	ret = snd_pcm_hw_constraint_integer(runtime,
-					    SNDRV_PCM_HW_PARAM_PERIODS);
-	if (ret < 0)
-		return ret;
-
 	dma_data = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream);
-	ret = snd_dmaengine_pcm_open(substream, omap_dma_filter_fn,
-				     &dma_data->dma_req);
-	return ret;
+
+	return snd_dmaengine_pcm_open(substream, omap_dma_filter_fn,
+				      &dma_data->dma_req);
 }
 
 static int omap_pcm_close(struct snd_pcm_substream *substream)
-- 
1.8.1.1

Re: [PATCH] ASoC: omap-pcm: No need to set constraint at open time

[Jarkko Nikula]

On Tue, 5 Feb 2013 13:43:39 +0100
Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:

> The same constraint is going to be set in the snd_dmaengine_pcm_open()
> function, so there is no need to set it here as well.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  sound/soc/omap/omap-pcm.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
>
Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>

Re: [PATCH] ASoC: omap-pcm: No need to set constraint at open time

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 211 bytes --]

On Tue, Feb 05, 2013 at 01:43:39PM +0100, Peter Ujfalusi wrote:
> The same constraint is going to be set in the snd_dmaengine_pcm_open()
> function, so there is no need to set it here as well.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]