alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: vinod.koul@intel.com
Cc: alsa-devel@alsa-project.org
Subject: [PATCH TINYCOMPRESS 7/14] compress: Remove hardcoded limit on	length of poll() wait
Date: Sun, 10 Feb 2013 00:13:08 +0000	[thread overview]
Message-ID: <20130210001308.GG31139@opensource.wolfsonmicro.com> (raw)

For best power-saving we want to sleep on poll() for as long as
possible, we don't want to wake unnecessarily for arbitrary time
limits. Adds function compress_set_max_poll_wait() so that
client can configure the poll() timeout.

diff --git a/compress.c b/compress.c
index 5235ea4..b706f8b 100644
--- a/compress.c
+++ b/compress.c
@@ -77,12 +77,16 @@
 
 #define COMPR_ERR_MAX 32
 
+/* Default maximum time we will wait in a poll() - 20 seconds */
+#define DEFAULT_MAX_POLL_WAIT_MS    20000
+
 struct compress {
 	int fd;
 	unsigned int flags;
 	char error[COMPR_ERR_MAX];
 	struct compr_config config;
 	int running;
+	int max_poll_wait_ms;
 };
 
 static int oops(struct compress *compress, int e, const char *fmt, ...)
@@ -214,6 +218,8 @@ struct compress *compress_open(unsigned int card, unsigned int device,
 
 	snprintf(fn, sizeof(fn), "/dev/snd/comprC%uD%u", card, device);
 
+	compress->max_poll_wait_ms = DEFAULT_MAX_POLL_WAIT_MS;
+
 	compress->flags = flags;
 	if (!((flags & COMPRESS_OUT) || (flags & COMPRESS_IN))) {
 		oops(compress, -EINVAL, "can't deduce device direction from given flags\n");
@@ -321,8 +327,8 @@ int compress_write(struct compress *compress, const void *buf, unsigned int size
 
 		/* we will write only when avail > fragment size */
 		if (avail.avail < compress->config.fragment_size) {
-			/* nothing to write so wait for 10secs */
-			ret = poll(&fds, 1, 1000000);
+			/* nothing to write so wait */
+			ret = poll(&fds, 1, compress->max_poll_wait_ms);
 			if (ret < 0)
 				return oops(compress, errno, "poll error");
 			if (ret == 0)
@@ -432,3 +438,8 @@ bool is_codec_supported(unsigned int card, unsigned int device,
 	return ret;
 }
 
+void compress_set_max_poll_wait(struct compress *compress, int milliseconds)
+{
+	compress->max_poll_wait_ms = milliseconds;
+}
+
diff --git a/include/tinycompress/tinycompress.h b/include/tinycompress/tinycompress.h
index e285bd4..1ab53c6 100644
--- a/include/tinycompress/tinycompress.h
+++ b/include/tinycompress/tinycompress.h
@@ -189,6 +189,16 @@ int compress_drain(struct compress *compress);
 bool is_codec_supported(unsigned int card, unsigned int device,
 	       unsigned int flags, struct snd_codec *codec);
 
+/*
+ * compress_set_max_poll_wait: set the maximum time tinycompress
+ * will wait for driver to signal a poll(). Interval is in
+ * milliseconds.
+ * Pass interval of -1 to disable timeout and make poll() wait
+ * until driver signals.
+ * If this function is not used the timeout defaults to 20 seconds.
+ */
+void compress_set_max_poll_wait(struct compress *compress, int milliseconds);
+
 int is_compress_running(struct compress *compress);
 
 int is_compress_ready(struct compress *compress);
-- 
1.7.2.5

             reply	other threads:[~2013-02-10  0:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-10  0:13 Richard Fitzgerald [this message]
2013-02-11  6:45 ` [PATCH TINYCOMPRESS 7/14] compress: Remove hardcoded limit on length of poll() wait Vinod Koul
2013-02-22 16:03 ` [PATCH TINYCOMPRESS 7/14 v2] " Richard Fitzgerald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130210001308.GG31139@opensource.wolfsonmicro.com \
    --to=rf@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).