* [PATCH] ASoC: omap-dmic: Clean up with devm_request_and_ioremap
@ 2013-02-13 7:22 Sebastien Guiriec
2013-02-13 13:15 ` Peter Ujfalusi
2013-02-13 13:24 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Sebastien Guiriec @ 2013-02-13 7:22 UTC (permalink / raw)
To: Sebastien Guiriec, Peter Ujfalusi, Jarkko Nikula, Liam Girdwood,
Mark Brown, linux-omap, alsa-devel
Clean up dmic code with devm_request_and_ioremap function.
Signed-off-by: Sebastien Guiriec <s-guiriec@ti.com>
---
sound/soc/omap/omap-dmic.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
index ba49ccd..77e9e7e 100644
--- a/sound/soc/omap/omap-dmic.c
+++ b/sound/soc/omap/omap-dmic.c
@@ -493,16 +493,9 @@ static int asoc_dmic_probe(struct platform_device *pdev)
goto err_put_clk;
}
- if (!devm_request_mem_region(&pdev->dev, res->start,
- resource_size(res), pdev->name)) {
- dev_err(dmic->dev, "memory region already claimed\n");
- ret = -ENODEV;
- goto err_put_clk;
- }
-
- dmic->io_base = devm_ioremap(&pdev->dev, res->start,
- resource_size(res));
+ dmic->io_base = devm_request_and_ioremap(&pdev->dev, res);
if (!dmic->io_base) {
+ dev_err(&pdev->dev, "cannot remap\n");
ret = -ENOMEM;
goto err_put_clk;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: omap-dmic: Clean up with devm_request_and_ioremap
2013-02-13 7:22 [PATCH] ASoC: omap-dmic: Clean up with devm_request_and_ioremap Sebastien Guiriec
@ 2013-02-13 13:15 ` Peter Ujfalusi
2013-02-13 13:24 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2013-02-13 13:15 UTC (permalink / raw)
To: Sebastien Guiriec
Cc: Jarkko Nikula, Liam Girdwood, Mark Brown, linux-omap, alsa-devel
On 02/13/2013 08:22 AM, Sebastien Guiriec wrote:
> Clean up dmic code with devm_request_and_ioremap function.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Sebastien Guiriec <s-guiriec@ti.com>
> ---
> sound/soc/omap/omap-dmic.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
> index ba49ccd..77e9e7e 100644
> --- a/sound/soc/omap/omap-dmic.c
> +++ b/sound/soc/omap/omap-dmic.c
> @@ -493,16 +493,9 @@ static int asoc_dmic_probe(struct platform_device *pdev)
> goto err_put_clk;
> }
>
> - if (!devm_request_mem_region(&pdev->dev, res->start,
> - resource_size(res), pdev->name)) {
> - dev_err(dmic->dev, "memory region already claimed\n");
> - ret = -ENODEV;
> - goto err_put_clk;
> - }
> -
> - dmic->io_base = devm_ioremap(&pdev->dev, res->start,
> - resource_size(res));
> + dmic->io_base = devm_request_and_ioremap(&pdev->dev, res);
> if (!dmic->io_base) {
> + dev_err(&pdev->dev, "cannot remap\n");
> ret = -ENOMEM;
> goto err_put_clk;
> }
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: omap-dmic: Clean up with devm_request_and_ioremap
2013-02-13 7:22 [PATCH] ASoC: omap-dmic: Clean up with devm_request_and_ioremap Sebastien Guiriec
2013-02-13 13:15 ` Peter Ujfalusi
@ 2013-02-13 13:24 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-02-13 13:24 UTC (permalink / raw)
To: Sebastien Guiriec
Cc: Peter Ujfalusi, Jarkko Nikula, Liam Girdwood, linux-omap,
alsa-devel
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
On Wed, Feb 13, 2013 at 08:22:07AM +0100, Sebastien Guiriec wrote:
> Clean up dmic code with devm_request_and_ioremap function.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-13 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-13 7:22 [PATCH] ASoC: omap-dmic: Clean up with devm_request_and_ioremap Sebastien Guiriec
2013-02-13 13:15 ` Peter Ujfalusi
2013-02-13 13:24 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).