From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
jerry.wong@maximintegrated.com, kuninori.morimoto.gx@renesas.com
Subject: Re: [PATCH 4/5] ASoC: max98090: Remove unnecessary braces
Date: Wed, 20 Feb 2013 16:52:58 +0000 [thread overview]
Message-ID: <20130220165258.GK2726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1361187134-7525-4-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 476 bytes --]
On Mon, Feb 18, 2013 at 05:02:13PM +0530, Sachin Kamat wrote:
> - if (val >= 1) {
> - if (w->reg == M98090_REG_MIC1_INPUT_LEVEL) {
> + if (val >= 1){
Your coding style fixes shouldn't introduce new coding style issues
and...
> + if (w->reg == M98090_REG_MIC1_INPUT_LEVEL)
...in cases where you're nesting with other if statements it's often
clearer to have the braces consistently over all levels of the
conditional.
For the isolated if statements this is fine though.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-02-20 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 11:32 [PATCH 1/5] ASoC: max98090: Remove unneeded version.h header include Sachin Kamat
2013-02-18 11:32 ` [PATCH 2/5] ASoC: max98090: Convert to devm_regmap_init_i2c() Sachin Kamat
2013-02-20 16:58 ` Mark Brown
2013-02-18 11:32 ` [PATCH 3/5] ASoC: max98090: Make struct dev_pm_ops const Sachin Kamat
2013-02-20 16:58 ` Mark Brown
2013-02-18 11:32 ` [PATCH 4/5] ASoC: max98090: Remove unnecessary braces Sachin Kamat
2013-02-20 16:52 ` Mark Brown [this message]
2013-02-25 4:14 ` Sachin Kamat
2013-02-18 11:32 ` [PATCH 5/5] ASoC: max98090: Fix checkpatch errors related to spacing Sachin Kamat
2013-02-20 17:02 ` Mark Brown
2013-02-20 16:58 ` [PATCH 1/5] ASoC: max98090: Remove unneeded version.h header include Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220165258.GK2726@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jerry.wong@maximintegrated.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=sachin.kamat@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).