From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: vinod.koul@intel.com
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH TINYCOMPRESS 4/14 v2] compress: Change running from bitfield to plain int
Date: Fri, 22 Feb 2013 15:59:54 +0000 [thread overview]
Message-ID: <20130222155954.GD21174@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130210000806.GD31139@opensource.wolfsonmicro.com>
Declaring running as a single-bit bitfield does not save any space
or give any coding advantages, but does leave potential opportunities
for the compiler to be inefficient in how it handles bitfields compared
to how it would handle a machine int.
---
compress.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/compress.c b/compress.c
index 3cd0f85..d09e161 100644
--- a/compress.c
+++ b/compress.c
@@ -82,7 +82,7 @@ struct compress {
unsigned int flags;
char error[COMPR_ERR_MAX];
struct compr_config *config;
- unsigned int running:1;
+ int running;
};
static int oops(struct compress *compress, int e, const char *fmt, ...)
--
1.7.2.5
prev parent reply other threads:[~2013-02-22 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 0:08 [PATCH TINYCOMPRESS 4/14] compress: Change running from bitfield to plain int Richard Fitzgerald
2013-02-22 15:59 ` Richard Fitzgerald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222155954.GD21174@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).