From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Simon <horms@verge.net.au>,
Liam Girdwood <liam.r.girdwood@intel.com>,
Shawn Guo <shawn.guo@linaro.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH 19/54 v2] ASoC: switch over to use snd_soc_register_component() on mpc5200 i2s
Date: Fri, 22 Mar 2013 11:26:16 +0100 [thread overview]
Message-ID: <20130322102616.GE22890@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <514BE645.2050409@wwwdotorg.org>
[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]
On Thu, Mar 21, 2013 at 11:04:05PM -0600, Stephen Warren wrote:
> On 03/21/2013 07:19 PM, Kuninori Morimoto wrote:
> However, I do see:
> > ./mpc8610_hpcd.c:213: machine_data->dai[0].cpu_dai_name = dev_name(&ssi_pdev->dev);
> > ./p1022_ds.c:223: mdata->dai[0].cpu_dai_name = dev_name(&ssi_pdev->dev);
> > ./p1022_rdk.c:226: mdata->dai[0].cpu_dai_name = dev_name(&ssi_pdev->dev);
> > ./imx-sgtl5000.c:151: data->dai.cpu_dai_name = dev_name(&ssi_pdev->dev);
> That's a bit icky; DT-based systems should use .cpu_of_node, not
> .cpu_dai_name...
With the exception of the SGTL5000 one those are all very old school
ASoC DT drivers that predate any framework involvement or review outside
of the driver.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-03-22 10:26 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 6:18 [PATCH 0/53] ASoC: switch over to use snd_soc_register_component() Kuninori Morimoto
2013-03-18 6:19 ` [PATCH 01/53] ASoC: switch over to use snd_soc_register_component() on atmel ssc Kuninori Morimoto, Kuninori Morimoto
2013-03-18 6:19 ` [PATCH 02/53] ASoC: switch over to use snd_soc_register_component() on au1x i2sc Kuninori Morimoto, Kuninori Morimoto
2013-03-18 6:20 ` [PATCH 03/53] ASoC: switch over to use snd_soc_register_component() on au1x psc-ac97 Kuninori Morimoto, Kuninori Morimoto
2013-03-18 6:20 ` [PATCH 04/53] ASoC: switch over to use snd_soc_register_component() on au1x psc-i2s Kuninori Morimoto, Kuninori Morimoto
2013-03-18 6:20 ` [PATCH 05/53] ASoC: switch over to use snd_soc_register_component() on au1x ac97c Kuninori Morimoto
2013-03-18 6:20 ` [PATCH 06/53] ASoC: switch over to use snd_soc_register_component() on bf6xx i2s Kuninori Morimoto
2013-03-18 6:20 ` [PATCH 07/53] ASoC: switch over to use snd_soc_register_component() on bf5xx ac97 Kuninori Morimoto
2013-03-18 6:21 ` [PATCH 08/53] ASoC: switch over to use snd_soc_register_component() on bf5xx i2s Kuninori Morimoto
2013-03-18 6:21 ` [PATCH 09/53] ASoC: switch over to use snd_soc_register_component() on bf5xx tdm Kuninori Morimoto
2013-03-18 6:21 ` [PATCH 10/53] ASoC: switch over to use snd_soc_register_component() on ep93xx ac97 Kuninori Morimoto
2013-03-18 6:22 ` [PATCH 11/53] ASoC: switch over to use snd_soc_register_component() on ep93xx i2s Kuninori Morimoto
2013-03-18 6:23 ` [PATCH 12/53] ASoC: switch over to use snd_soc_register_component() on davinci i2s Kuninori Morimoto
2013-03-18 6:23 ` [PATCH 13/53] ASoC: switch over to use snd_soc_register_component() on davinci vcif Kuninori Morimoto
2013-03-18 6:23 ` [PATCH 14/53] ASoC: switch over to use snd_soc_register_component() on davinci mcasp Kuninori Morimoto
2013-03-18 6:23 ` [PATCH 15/53] ASoC: switch over to use snd_soc_register_component() on dw i2s Kuninori Morimoto
2013-03-18 6:23 ` [PATCH 16/53] ASoC: switch over to use snd_soc_register_component() on mpc5200 ac97 Kuninori Morimoto
2013-03-18 6:24 ` [PATCH 17/53] ASoC: switch over to use snd_soc_register_component() on mpc5200 i2s Kuninori Morimoto
2013-03-18 6:24 ` [PATCH 18/53] ASoC: switch over to use snd_soc_register_component() on fsl ssi Kuninori Morimoto
2013-03-18 6:24 ` [PATCH 19/53] ASoC: switch over to use snd_soc_register_component() on imx ssi Kuninori Morimoto
2013-03-18 6:24 ` [PATCH 20/53] ASoC: switch over to use snd_soc_register_component() on jz4740 i2s Kuninori Morimoto
2013-03-18 6:24 ` [PATCH 21/53] ASoC: switch over to use snd_soc_register_component() on kirkwood i2s Kuninori Morimoto
2013-03-18 6:24 ` [PATCH 22/53] ASoC: switch over to use snd_soc_register_component() on sst Kuninori Morimoto
2013-03-18 6:24 ` [PATCH 23/53] ASoC: switch over to use snd_soc_register_component() on mxs saif Kuninori Morimoto
2013-03-18 6:25 ` [PATCH 24/53] ASoC: switch over to use snd_soc_register_component() on nuc900 ac97 Kuninori Morimoto
2013-03-18 6:25 ` [PATCH 25/53] ASoC: switch over to use snd_soc_register_component() on omap mcbsp Kuninori Morimoto
2013-03-19 12:36 ` Peter Ujfalusi
2013-03-18 6:25 ` [PATCH 26/53] ASoC: switch over to use snd_soc_register_component() on omap mcpdm Kuninori Morimoto
2013-03-18 6:25 ` [PATCH 27/53] ASoC: switch over to use snd_soc_register_component() on omap dmic Kuninori Morimoto
2013-03-18 6:26 ` [PATCH 28/53] ASoC: switch over to use snd_soc_register_component() on omap hdmi Kuninori Morimoto
2013-03-18 6:26 ` [PATCH 29/53] ASoC: switch over to use snd_soc_register_component() on pxa ssp Kuninori Morimoto
2013-03-18 6:26 ` [PATCH 30/53] ASoC: pxa2xx-ac97: move EXPORT_SYMBOL_GPL() next to definition Kuninori Morimoto
2013-03-18 6:26 ` [PATCH 31/53] ASoC: switch over to use snd_soc_register_component() on pxa2xx ac97 Kuninori Morimoto
2013-03-18 6:26 ` [PATCH 32/53] ASoC: switch over to use snd_soc_register_component() on pxa2xx i2s Kuninori Morimoto
2013-03-18 6:26 ` [PATCH 33/53] ASoC: switch over to use snd_soc_register_component() on mmp sspa Kuninori Morimoto
2013-03-18 6:27 ` [PATCH 34/53] ASoC: switch over to use snd_soc_register_component() on s6000 i2s Kuninori Morimoto
2013-03-18 6:27 ` [PATCH 35/53] ASoC: switch over to use snd_soc_register_component() on s3c24xx i2s Kuninori Morimoto
2013-03-18 6:33 ` [PATCH 01/18] ASoC: switch over to use snd_soc_register_component() on s3c i2s Kuninori Morimoto
2013-03-18 6:33 ` [PATCH 37/53] ASoC: switch over to use snd_soc_register_component() on s3c ac97 Kuninori Morimoto
2013-03-18 6:33 ` [PATCH 38/53] ASoC: switch over to use snd_soc_register_component() on samsung spdif Kuninori Morimoto
2013-03-18 6:33 ` [PATCH 39/53] ASoC: switch over to use snd_soc_register_component() on samsung i2s Kuninori Morimoto
2013-03-18 6:33 ` [PATCH 40/53] ASoC: switch over to use snd_soc_register_component() on samsung pcm Kuninori Morimoto
2013-03-18 6:34 ` [PATCH 41/53] ASoC: switch over to use snd_soc_register_component() on goni_wm8994 Kuninori Morimoto
2013-03-18 6:34 ` [PATCH 42/53] ASoC: switch over to use snd_soc_register_component() on sh4 ssi Kuninori Morimoto
2013-03-18 6:34 ` [PATCH 43/53] ASoC: switch over to use snd_soc_register_component() on sh4 siu Kuninori Morimoto
2013-03-18 6:34 ` [PATCH 44/53] ASoC: switch over to use snd_soc_register_component() on sh4 hac Kuninori Morimoto
2013-03-18 6:34 ` [PATCH 45/53] ASoC: switch over to use snd_soc_register_component() on spear spdif out Kuninori Morimoto
2013-03-18 6:34 ` [PATCH 46/53] ASoC: switch over to use snd_soc_register_component() on spear spdif in Kuninori Morimoto
2013-03-18 6:34 ` [PATCH 47/53] ASoC: switch over to use snd_soc_register_component() on tegra30 i2s Kuninori Morimoto
2013-03-18 15:39 ` Stephen Warren
2013-03-18 6:35 ` [PATCH 48/53] ASoC: switch over to use snd_soc_register_component() on tegra20 spdif Kuninori Morimoto
2013-03-18 6:35 ` [PATCH 49/53] ASoC: switch over to use snd_soc_register_component() on tegra20 ac97 Kuninori Morimoto
2013-03-18 6:35 ` [PATCH 50/53] ASoC: switch over to use snd_soc_register_component() on tegra20 i2s Kuninori Morimoto
2013-03-18 6:35 ` [PATCH 51/53] ASoC: switch over to use snd_soc_register_component() on txx9aclc ac97 Kuninori Morimoto
2013-03-18 6:35 ` [PATCH 52/53] ASoC: switch over to use snd_soc_register_component() on ux500 msp Kuninori Morimoto
2013-03-18 6:35 ` [PATCH 53/53] ASoC: snd_soc_[un]register_dai[s]() become non global function Kuninori Morimoto
2013-03-18 15:44 ` [PATCH 0/53] ASoC: switch over to use snd_soc_register_component() Lars-Peter Clausen
2013-03-19 0:32 ` Kuninori Morimoto
2013-03-19 0:36 ` [PATCH] ASoC: snd_soc_register_component() uses properly snd_soc_register_dai[s]() Kuninori Morimoto
2013-03-19 8:35 ` [PATCH 0/53] ASoC: switch over to use snd_soc_register_component() Lars-Peter Clausen
2013-03-19 15:38 ` Stephen Warren
2013-03-21 0:14 ` Kuninori Morimoto
2013-03-21 10:26 ` [PATCH 0/54 v2] " Kuninori Morimoto
2013-03-21 10:27 ` [PATCH 01/54 v2] ASoC: snd_soc_register_component() uses properly snd_soc_register_dai[s]() Kuninori Morimoto
2013-03-21 10:27 ` [PATCH 02/54 v2] ASoC: pxa2xx-ac97: move EXPORT_SYMBOL_GPL() next to definition Kuninori Morimoto
2013-03-22 11:13 ` Mark Brown
2013-03-21 10:28 ` [PATCH 03/54 v2] ASoC: switch over to use snd_soc_register_component() on atmel ssc Kuninori Morimoto
2013-03-21 10:28 ` [PATCH 04/54 v2] ASoC: switch over to use snd_soc_register_component() on au1x i2sc Kuninori Morimoto
2013-03-21 10:28 ` [PATCH 05/54 v2] ASoC: switch over to use snd_soc_register_component() on au1x psc-ac97 Kuninori Morimoto
2013-03-21 10:29 ` [PATCH 06/54 v2] ASoC: switch over to use snd_soc_register_component() on au1x psc-i2s Kuninori Morimoto
2013-03-21 10:29 ` [PATCH 07/54] ASoC: switch over to use snd_soc_register_component() on au1x ac97c Kuninori Morimoto
2013-03-21 10:29 ` [PATCH 08/54 v2] ASoC: switch over to use snd_soc_register_component() on bf6xx i2s Kuninori Morimoto
2013-03-21 10:29 ` [PATCH 09/54 v2] ASoC: switch over to use snd_soc_register_component() on bf5xx ac97 Kuninori Morimoto
2013-03-21 10:30 ` [PATCH 10/54 v2] ASoC: switch over to use snd_soc_register_component() on bf5xx i2s Kuninori Morimoto
2013-03-21 10:30 ` [PATCH 11/54 v2] ASoC: switch over to use snd_soc_register_component() on bf5xx tdm Kuninori Morimoto
2013-03-21 10:30 ` [PATCH 12/54 v2] ASoC: switch over to use snd_soc_register_component() on ep93xx ac97 Kuninori Morimoto
2013-03-21 10:30 ` [PATCH 13/54 v2] ASoC: switch over to use snd_soc_register_component() on ep93xx i2s Kuninori Morimoto
2013-03-21 10:30 ` [PATCH 14/54 v2] ASoC: switch over to use snd_soc_register_component() on davinci i2s Kuninori Morimoto
2013-03-21 10:31 ` [PATCH 15/54 v2] ASoC: switch over to use snd_soc_register_component() on davinci vcif Kuninori Morimoto
2013-03-21 10:31 ` [PATCH 16/54 v2] ASoC: switch over to use snd_soc_register_component() on davinci mcasp Kuninori Morimoto
2013-03-21 10:31 ` [PATCH 17/54 v2] ASoC: switch over to use snd_soc_register_component() on dw i2s Kuninori Morimoto
2013-03-21 10:31 ` [PATCH 18/54 v2] ASoC: switch over to use snd_soc_register_component() on mpc5200 ac97 Kuninori Morimoto
2013-03-21 10:31 ` [PATCH 19/54 v2] ASoC: switch over to use snd_soc_register_component() on mpc5200 i2s Kuninori Morimoto
2013-03-21 16:53 ` Stephen Warren
2013-03-22 1:19 ` Kuninori Morimoto
2013-03-22 5:04 ` Stephen Warren
2013-03-22 10:26 ` Mark Brown [this message]
2013-03-25 0:24 ` Kuninori Morimoto
2013-03-25 15:58 ` Stephen Warren
2013-03-25 3:11 ` Shawn Guo
2013-03-22 10:22 ` Mark Brown
2013-03-21 10:32 ` [PATCH 20/54 v2] ASoC: switch over to use snd_soc_register_component() on fsl ssi Kuninori Morimoto
2013-03-21 10:32 ` [PATCH 21/54 v2] ASoC: switch over to use snd_soc_register_component() on imx ssi Kuninori Morimoto
2013-03-21 10:32 ` [PATCH 22/54 v2] ASoC: switch over to use snd_soc_register_component() on jz4740 i2s Kuninori Morimoto
2013-03-25 10:48 ` Lars-Peter Clausen
2013-03-21 10:32 ` [PATCH 23/54 v2] ASoC: switch over to use snd_soc_register_component() on kirkwood i2s Kuninori Morimoto
2013-03-21 10:32 ` [PATCH 24/54 v2] ASoC: switch over to use snd_soc_register_component() on sst Kuninori Morimoto
2013-03-21 10:33 ` [PATCH 25/54 v2] ASoC: switch over to use snd_soc_register_component() on mxs saif Kuninori Morimoto
2013-03-21 10:33 ` [PATCH 26/54 v2] ASoC: switch over to use snd_soc_register_component() on nuc900 ac97 Kuninori Morimoto
2013-03-21 10:33 ` [PATCH 27/54 v2] ASoC: switch over to use snd_soc_register_component() on omap mcbsp Kuninori Morimoto
2013-03-21 10:33 ` [PATCH 28/54 v2] ASoC: switch over to use snd_soc_register_component() on omap mcpdm Kuninori Morimoto
2013-03-21 10:33 ` [PATCH 29/54 v2] ASoC: switch over to use snd_soc_register_component() on omap dmic Kuninori Morimoto
2013-03-21 10:34 ` [PATCH 30/54 v2] ASoC: switch over to use snd_soc_register_component() on omap hdmi Kuninori Morimoto
2013-03-21 10:34 ` [PATCH 31/54 v2] ASoC: switch over to use snd_soc_register_component() on pxa ssp Kuninori Morimoto
2013-03-21 10:34 ` [PATCH 32/54 v2] ASoC: switch over to use snd_soc_register_component() on pxa2xx ac97 Kuninori Morimoto
2013-03-21 10:34 ` [PATCH 33/54 v2] ASoC: switch over to use snd_soc_register_component() on pxa2xx i2s Kuninori Morimoto
2013-03-21 10:34 ` [PATCH 34/54 v2] ASoC: switch over to use snd_soc_register_component() on mmp sspa Kuninori Morimoto
2013-03-21 10:34 ` [PATCH 35/54 v2] ASoC: switch over to use snd_soc_register_component() on s6000 i2s Kuninori Morimoto
2013-03-21 10:35 ` [PATCH 36/54 v2] ASoC: switch over to use snd_soc_register_component() on s3c24xx i2s Kuninori Morimoto
2013-03-21 10:35 ` [PATCH 37/54 v2] ASoC: switch over to use snd_soc_register_component() on s3c i2s Kuninori Morimoto
2013-03-21 10:35 ` [PATCH 38/54 v2] ASoC: switch over to use snd_soc_register_component() on s3c ac97 Kuninori Morimoto
2013-03-21 10:35 ` [PATCH 39/54 v2] ASoC: switch over to use snd_soc_register_component() on samsung spdif Kuninori Morimoto
2013-03-21 10:35 ` [PATCH 40/54 v2] ASoC: switch over to use snd_soc_register_component() on samsung i2s Kuninori Morimoto
2013-03-21 10:36 ` [PATCH 41/54 v2] ASoC: switch over to use snd_soc_register_component() on samsung pcm Kuninori Morimoto
2013-03-21 10:36 ` [PATCH 42/54 v2] ASoC: switch over to use snd_soc_register_component() on goni_wm8994 Kuninori Morimoto
2013-03-21 10:36 ` [PATCH 43/54 v2] ASoC: switch over to use snd_soc_register_component() on sh4 ssi Kuninori Morimoto
2013-03-21 16:58 ` Stephen Warren
2013-03-22 0:17 ` Kuninori Morimoto
2013-03-21 10:36 ` [PATCH 44/54 v2] ASoC: switch over to use snd_soc_register_component() on sh4 siu Kuninori Morimoto
2013-03-21 17:00 ` Stephen Warren
2013-03-22 0:21 ` Kuninori Morimoto
2013-03-22 4:39 ` Stephen Warren
2013-03-22 7:54 ` [PATCH 44/54 v3] " Kuninori Morimoto
2013-03-21 10:36 ` [PATCH 45/54 v2] ASoC: switch over to use snd_soc_register_component() on sh4 hac Kuninori Morimoto
2013-03-21 17:01 ` Stephen Warren
2013-03-22 0:25 ` Kuninori Morimoto
2013-03-22 4:44 ` Stephen Warren
2013-03-21 10:37 ` [PATCH 46/54 v2] ASoC: switch over to use snd_soc_register_component() on spear spdif out Kuninori Morimoto
2013-03-21 10:37 ` [PATCH 47/54 v2] ASoC: switch over to use snd_soc_register_component() on spear spdif in Kuninori Morimoto
2013-03-21 10:37 ` [PATCH 48/54 v2] ASoC: switch over to use snd_soc_register_component() on tegra30 i2s Kuninori Morimoto
2013-03-21 10:37 ` [PATCH 49/54 v2] ASoC: switch over to use snd_soc_register_component() on tegra20 spdif Kuninori Morimoto
2013-03-21 10:37 ` [PATCH 50/54 v2] ASoC: switch over to use snd_soc_register_component() on tegra20 ac97 Kuninori Morimoto
2013-03-21 17:03 ` Stephen Warren
[not found] ` <1363886347.1846.10.camel@antimon>
2013-03-21 17:20 ` Stephen Warren
2013-03-21 10:37 ` [PATCH 51/54 v2] ASoC: switch over to use snd_soc_register_component() on tegra20 i2s Kuninori Morimoto
2013-03-21 10:38 ` [PATCH 52/54 v2] ASoC: switch over to use snd_soc_register_component() on txx9aclc ac97 Kuninori Morimoto
2013-03-21 10:38 ` [PATCH 53/54 v2] ASoC: switch over to use snd_soc_register_component() on ux500 msp Kuninori Morimoto
2013-03-21 10:38 ` [PATCH 54/54 v2] ASoC: snd_soc_[un]register_dai[s]() become non global function Kuninori Morimoto
2013-03-26 21:56 ` [PATCH 0/54 v2] ASoC: switch over to use snd_soc_register_component() Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322102616.GE22890@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=liam.r.girdwood@intel.com \
--cc=peter.ujfalusi@ti.com \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox