Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alban Bedel <alban.bedel@avionic-design.de>
Cc: alsa-devel@alsa-project.org, patch@alsa-project.org,
	Takashi Iwai <tiwai@suse.de>,
	patches@opensource.wolfsonmicro.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 2/2] ASoC: wm8903: Fix the bypass to HP/LINEOUT when no DAC or ADC is running
Date: Tue, 9 Apr 2013 15:33:12 +0100	[thread overview]
Message-ID: <20130409143312.GQ9243@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1363797453-24723-2-git-send-email-alban.bedel@avionic-design.de>


[-- Attachment #1.1: Type: text/plain, Size: 665 bytes --]

On Wed, Mar 20, 2013 at 05:37:33PM +0100, Alban Bedel wrote:

> output enable sequence requiere the DSP clock. Some input from Wolfson
> will be needed to find out if this is just an undocumented requirement
> or a chip bug.

It seems it's an undocumented requirement.

> +	{ "Left Output Mixer", "Left Bypass Switch", "CLK_DSP" },
> +	{ "Left Output Mixer", "Right Bypass Switch", "CLK_DSP" },
> +	{ "Right Output Mixer", "Left Bypass Switch", "CLK_DSP" },
> +	{ "Right Output Mixer", "Right Bypass Switch", "CLK_DSP" },

The actual change here should be to add a route:

	{ "Charge Pump", NULL, "CLK_DSP" },

Can you submit an update for this or should I do one?

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



      parent reply	other threads:[~2013-04-09 14:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1363797453-24723-1-git-send-email-alban.bedel@avionic-design.de>
2013-03-20 19:23 ` [PATCH 1/2] ASoC: wm8903: Add the DAC boost control Mark Brown
     [not found] ` <1363797453-24723-2-git-send-email-alban.bedel@avionic-design.de>
2013-04-09 14:33   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130409143312.GQ9243@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alban.bedel@avionic-design.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=grant.likely@secretlab.ca \
    --cc=lgirdwood@gmail.com \
    --cc=patch@alsa-project.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=rob.herring@calxeda.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox