Re: [PATCH] ASoC: add RT5640 CODEC driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 931 bytes --]

On Wed, Apr 17, 2013 at 09:18:30AM -0600, Stephen Warren wrote:
> On 04/17/2013 08:01 AM, Mark Brown wrote:

> > That said if boards generally don't use external supplies and use
> > the built in regulators then it's probably best to at least have
> > the driver assume that by default.

> So the issue here is that regulators aren't supposed to be optional,
> right? So if there's a reasonable chance that regulators would ever be
> needed, we should add them now.

> With board files, we probably could have just added them later, but
> with device tree (which is my use-case for this CODEC at least), the
> DT binding needs to specify which regulator(s) the device requires (if
> any) right from the start, so that all DTs will include the regulator
> definitions.

You can do the same thing with DT as you do with board files - make
those supplies an optional property and then if the property is missing
do the default thing.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]